Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest removing redundant arguments in format!() #115324

Merged
merged 12 commits into from
Oct 23, 2023
Merged

Suggest removing redundant arguments in format!() #115324

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
93df9e6
Suggest removing redundant arguments in format!()
francorbacho Aug 28, 2023
4cc2d0b
Separate report_redundant_placeholders() into its own function
francorbacho Sep 25, 2023
04fc051
Use diagnostic impls and add suggestions in redundant format!() args
francorbacho Oct 4, 2023
9c921f8
Rename report_redundant_placeholders() to report_redundant_format_arg…
francorbacho Oct 4, 2023
e1c18f4
Document report_redundant_format_arguments()
francorbacho Oct 4, 2023
dc75c99
Remove unused variable
francorbacho Oct 4, 2023
4a7a98c
Fix diagnostics being cancelled even with unused arguments
francorbacho Oct 5, 2023
fcdd5c0
Plurals in format redundant arguments suggestion
francorbacho Oct 5, 2023
905bace
Highlight redundant arguments instead of the whole format string
francorbacho Oct 5, 2023
38b0182
Add suggestion test
francorbacho Oct 5, 2023
c8ee7db
Only give autofix suggestion when no named args are present
francorbacho Oct 5, 2023
cbc6b65
Keep fluent slugs in alphabetical order
francorbacho Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename report_redundant_placeholders() to report_redundant_format_arg… 
…uments()
  • Loading branch information
@francorbacho
francorbacho committed Oct 5, 2023
commit 9c921f843c78a98b8b0eaa40f2b20b60543ebf53
4 changes: 2 additions & 2 deletions compiler/rustc_builtin_macros/src/format.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,7 +616,7 @@ fn report_missing_placeholders(
.collect::<Vec<_>>();

if !placeholders.is_empty() {
report_redundant_placeholders(ecx, fmt_span, &args, used, placeholders);
report_redundant_format_arguments(ecx, fmt_span, &args, used, placeholders);
diag.cancel();
return;
}
Expand Down Expand Up @@ -708,7 +708,7 @@ fn report_missing_placeholders(
diag.emit();
}

fn report_redundant_placeholders(
fn report_redundant_format_arguments(
ecx: &mut ExtCtxt<'_>,
fmt_span: Span,
args: &FormatArguments,
Expand Down