Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for #104260 #105358

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Add a test for #104260 #105358

merged 1 commit into from
Dec 7, 2022

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Dec 6, 2022

Fixes #104260

@rustbot
Copy link
Collaborator

rustbot commented Dec 6, 2022

r? @estebank

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 6, 2022
@estebank
Copy link
Contributor

estebank commented Dec 6, 2022

I didn't know we allowed type A<T> = B; where B has no params ^_^

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 6, 2022

📌 Commit d15ca09 has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 6, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 6, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 7, 2022
@bors
Auto merge of rust-lang#105397 - matthiaskrgr:rollup-xv5imz8, r=matth…
d43674e 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#105298 (llvm-wrapper: adapt for an LLVM API change)
 - rust-lang#105358 (Add a test for rust-lang#104260)
 - rust-lang#105380 (add const generics ping files things for me)
 - rust-lang#105382 (remove an excess `this`)
 - rust-lang#105388 (rustdoc: remove redundant CSS `.import-item .stab { font-size }`)
 - rust-lang#105390 (unstable-book: Add `ignore` to `abi_efiapi` example code)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 001bd51 into rust-lang:master Dec 7, 2022
@rustbot rustbot added this to the 1.67.0 milestone Dec 7, 2022
@TaKO8Ki TaKO8Ki deleted the fix-104260 branch December 7, 2022 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.

ICE with inherent generic associated type: no type for node HirId
4 participants
@TaKO8Ki @rustbot @estebank @bors