Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #102867

Merged
merged 18 commits into from
Oct 10, 2022
Merged

Rollup of 6 pull requests #102867

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
887515a
Trying to suggest additional lifetime parameter
Stoozy Sep 26, 2022
365457b
Using multipart suggestion
Stoozy Sep 27, 2022
24c8e27
Properly formatting the multipart suggestion
Stoozy Sep 27, 2022
e7cb6ad
Proper span for new generic param suggestion
Stoozy Sep 28, 2022
ef930a2
Emitting error regardless of new param suggestion
Stoozy Sep 29, 2022
2657f9d
Removed unnecessary for loop
Stoozy Oct 1, 2022
7b2f04a
fix #102182, recover from impl Trait in type param bound
chenyukang Sep 27, 2022
c084c26
Split slice part of feature(half_open_range_patterns) to [...]_in_slices
Urgau Oct 5, 2022
5ae7363
Stabilize half_open_range_patterns
Urgau Sep 24, 2022
f5fd66e
Elaborate trait ref to compute object safety.
cjgillot Oct 9, 2022
550f579
Add missing documentation for FileNameDisplayPreference variants
GuillaumeGomez Oct 9, 2022
0718aec
From<Alignment> for usize & NonZeroUsize
scottmcm Oct 9, 2022
c50e64d
Rollup merge of #102275 - Urgau:stabilize-half_open_range_patterns, r…
JohnTitor Oct 10, 2022
0db05f1
Rollup merge of #102323 - Stoozy:master, r=cjgillot
JohnTitor Oct 10, 2022
303ebd5
Rollup merge of #102345 - chenyukang:fix-102182-impl-trait, r=estebank
JohnTitor Oct 10, 2022
a4e5577
Rollup merge of #102845 - cjgillot:gat-object, r=fee1-dead
JohnTitor Oct 10, 2022
e435a05
Rollup merge of #102860 - GuillaumeGomez:missing-docs-FileNameDisplay…
JohnTitor Oct 10, 2022
6d35efe
Rollup merge of #102862 - scottmcm:more-alignment-traits, r=thomcc
JohnTitor Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Proper span for new generic param suggestion
  • Loading branch information
@Stoozy
Stoozy committed Sep 28, 2022
commit e7cb6ad8ce382ded99be31c95562c8d91a635b24
9 changes: 7 additions & 2 deletions compiler/rustc_resolve/src/late/lifetimes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1333,11 +1333,16 @@ impl<'a, 'tcx> LifetimeContext<'a, 'tcx> {
);

diag.span_label(lifetime_ref.span, "expected named lifetime parameter");

diag.multipart_suggestion("consider introducing a named lifetime parameter",
vec![
(lifetime_ref.span.shrink_to_hi(), "'a ".to_owned()),
(generics.span, "<'a>".to_owned())
match generics.span_for_param_suggestion() {
Some(_) => {
(self.tcx.sess.source_map().span_through_char(generics.span, '<').shrink_to_hi(), "'a, ".to_owned())
}
None => (generics.span, "<'a>".to_owned()),

}
], rustc_errors::Applicability::MaybeIncorrect);
diag.emit();

Expand Down
12 changes: 10 additions & 2 deletions src/test/ui/suggestions/impl-trait-missing-lifetime-gated.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,25 @@ error[E0658]: anonymous lifetimes in `impl Trait` are unstable
--> $DIR/impl-trait-missing-lifetime-gated.rs:5:31
|
LL | fn f(_: impl Iterator<Item = &'_ ()>) {}
| ^^
| ^^ expected named lifetime parameter
|
= help: add `#![feature(anonymous_lifetime_in_impl_trait)]` to the crate attributes to enable
help: consider introducing a named lifetime parameter
|
LL | fn f<'a>(_: impl Iterator<Item = &'_'a ()>) {}
| ++++ ++

error[E0658]: anonymous lifetimes in `impl Trait` are unstable
--> $DIR/impl-trait-missing-lifetime-gated.rs:8:31
|
LL | fn g(x: impl Iterator<Item = &'_ ()>) -> Option<&'_ ()> { x.next() }
| ^^
| ^^ expected named lifetime parameter
|
= help: add `#![feature(anonymous_lifetime_in_impl_trait)]` to the crate attributes to enable
help: consider introducing a named lifetime parameter
|
LL | fn g<'a>(x: impl Iterator<Item = &'_'a ()>) -> Option<&'_ ()> { x.next() }
| ++++ ++

error: aborting due to 4 previous errors

Expand Down