Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest adding an array length if possible #100590

Merged
merged 2 commits into from
Aug 16, 2022
Merged

Suggest adding an array length if possible #100590

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d1b5f0
suggest adding an array length if possible
TaKO8Ki Aug 15, 2022
12e609b
use `span_suggestion` instead of `span_suggestion_verbose`
TaKO8Ki Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
use span_suggestion instead of span_suggestion_verbose
  • Loading branch information
@TaKO8Ki
TaKO8Ki committed Aug 15, 2022
commit 12e609ba3cb7a395601c3b6762682248b0a325ad
4 changes: 2 additions & 2 deletions compiler/rustc_typeck/src/check/expr.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1328,9 +1328,9 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
{
match self.tcx.sess.diagnostic().steal_diagnostic(span, StashKey::UnderscoreForArrayLengths) {
Some(mut err) => {
err.span_suggestion_verbose(
err.span_suggestion(
span,
"consider adding an array length",
"consider specifying the array length",
array_len,
Applicability::MaybeIncorrect,
);
Expand Down
18 changes: 3 additions & 15 deletions src/test/ui/array-slice-vec/suggest-array-length.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,40 +20,28 @@ error[E0658]: using `_` for array lengths is unstable
--> $DIR/suggest-array-length.rs:5:22
|
LL | const Foo: [i32; _] = [1, 2, 3];
| ^
| ^ help: consider specifying the array length: `3`
|
= note: see issue #85077 <https://github.com/rust-lang/rust/issues/85077> for more information
= help: add `#![feature(generic_arg_infer)]` to the crate attributes to enable
help: consider adding an array length
|
LL | const Foo: [i32; 3] = [1, 2, 3];
| ~

error[E0658]: using `_` for array lengths is unstable
--> $DIR/suggest-array-length.rs:8:20
|
LL | let foo: [i32; _] = [1, 2, 3];
| ^
| ^ help: consider specifying the array length: `3`
|
= note: see issue #85077 <https://github.com/rust-lang/rust/issues/85077> for more information
= help: add `#![feature(generic_arg_infer)]` to the crate attributes to enable
help: consider adding an array length
|
LL | let foo: [i32; 3] = [1, 2, 3];
| ~

error[E0658]: using `_` for array lengths is unstable
--> $DIR/suggest-array-length.rs:11:20
|
LL | let bar: [i32; _] = [0; 3];
| ^
| ^ help: consider specifying the array length: `3`
|
= note: see issue #85077 <https://github.com/rust-lang/rust/issues/85077> for more information
= help: add `#![feature(generic_arg_infer)]` to the crate attributes to enable
help: consider adding an array length
|
LL | let bar: [i32; 3] = [0; 3];
| ~

error: aborting due to 6 previous errors

Expand Down
6 changes: 1 addition & 5 deletions src/test/ui/feature-gates/feature-gate-generic_arg_infer.normal.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,10 @@ error[E0658]: using `_` for array lengths is unstable
--> $DIR/feature-gate-generic_arg_infer.rs:14:18
|
LL | let _y: [u8; _] = [0; 3];
| ^
| ^ help: consider specifying the array length: `3`
|
= note: see issue #85077 <https://github.com/rust-lang/rust/issues/85077> for more information
= help: add `#![feature(generic_arg_infer)]` to the crate attributes to enable
help: consider adding an array length
|
LL | let _y: [u8; 3] = [0; 3];
| ~

error[E0747]: type provided when a constant was expected
--> $DIR/feature-gate-generic_arg_infer.rs:20:20
Expand Down