#[deprecated] lint doesn't trigger when overriding deprecated method

This doesn't give any warnings, even though std::error::Error::description is deprecated:
```rust
impl std::error::Error for E {
    fn description(&self) -> &str {
        ":)"
    }
}
```

It seems like this is a deliberate decision:

https://github.com/rust-lang/rust/blob/3dcb616888aac50d55160b025266d555dad937d9/compiler/rustc_passes/src/stability.rs#L763-L764

[Substituting that first `None` for `Some(impl_item_ref.id.hir_id())`](https://github.com/rust-lang/rust/pull/98991) makes it work.

Doing so results in the lint triggering in exactly one place in `std`:

https://github.com/rust-lang/rust/blob/3dcb616888aac50d55160b025266d555dad937d9/library/std/src/error.rs#L605-L609

That's because in all other cases, we have `#[allow(deprecated)]` there:

https://github.com/rust-lang/rust/blob/3dcb616888aac50d55160b025266d555dad937d9/library/std/src/error.rs#L597-L602

Which is suprising, as that lint doesn't tigger there, making that `#[allow]` unnecessary.

It seems as if it used to be necessary in the past, but now no longer is.

Did #[deprecated] trigger on overrides in the past? Was that behavior changed on purpose? Or is it a bug that it doesn't do that anymore?

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#[deprecated] lint doesn't trigger when overriding deprecated method #98990

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	// Pass `None` to skip deprecation warnings.
	self.tcx.check_stability(def_id, None, impl_item_ref.span, None);

	impl Error for Infallible {
	fn description(&self) -> &str {
	match *self {}
	}
	}

	impl Error for string::FromUtf16Error {
	#[allow(deprecated)]
	fn description(&self) -> &str {
	"invalid utf-16"
	}
	}