ui tests should just show the stderr diff

Currently, when a UI test fails, it prints a sort of overwhelming amount of stuff:

https://github.com/rust-lang/rust/blob/a3c3245e911919e2d9c09ed0ab696b26f2517303/src/tools/compiletest/src/runtest.rs#L2712-L2722

I think what I would like is something like:

If the expected text is empty, just dump the actual (normalized) output, so people can copy-and-paste it if they want. 

Else, just print the diff. And probably it'd be nice to strip off the "prefix" and "suffix" of unchanged lines, and just show the parts that vary (we could imagine breaking things into hunks).

	println!("normalized {}:\n{}\n", kind, actual);
	println!("expected {}:\n{}\n", kind, expected);
	println!("diff of {}:\n", kind);

	for diff in diff::lines(expected, actual) {
	match diff {
	diff::Result::Left(l) => println!("-{}", l),
	diff::Result::Both(l, _) => println!(" {}", l),
	diff::Result::Right(r) => println!("+{}", r),
	}
	}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ui tests should just show the stderr diff #46826

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development