Skip to content

unstable error message order #128532

Open
Open
@folkertdev

Description

In #125558 we ran into inconsistent ordering of error messages between CI and our local machines.

Our fix was to re-order the top-level definitions, so that global_asm! comes before a function containing inline asm!.

Here the first commit failed on CI, the second one works. The only change is ordering of top-level definitions: 08c8887 .. 8fd7cc9

gist containing source files because idk how long force pushes are kept

@oli-obk had this theory

It's probably some code iterating over a hashmap and invoking queries as it does. Should be fairly easy to find as it must be in thr backtrace of the error (you can get that with -Ztreat-err-as-bug=index_of_the_error_in_the_output)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    A-diagnosticsArea: Messages for errors, warnings, and lintsA-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)C-bugCategory: This is a bug.D-diagnostic-infraDiagnostics: Issues that affect all diagnostics, or relate to the diagnostic machinery itself.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions