Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recommended-bin-packages field in Cargo.toml #3383

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

recommended-bin-packages field in Cargo.toml #3383

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9c15ddc
recommended-bin-crates: Initial draft
not-my-profile Feb 4, 2023
1eaca13
recommended-bin-crates: Address feedback by Steffahn
not-my-profile Feb 4, 2023
d1515f2
recommended-bin-crates: Stylize Cargo subcommands without dash
not-my-profile Feb 4, 2023
9e15043
recommended-bin-crates: Rename to recommended-bin-packages
not-my-profile Feb 15, 2023
91dd59d
recommended-bin-packages: Fix terminology crate -> package
not-my-profile Feb 15, 2023
3bfc362
recommended-bin-packages: Clarify that packages are in the same registry
not-my-profile Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
recommended-bin-crates: Stylize Cargo subcommands without dash
  • Loading branch information
@not-my-profile
not-my-profile committed Feb 4, 2023
commit d1515f250ffbb25a8161e67c480e7f976a72da53
4 changes: 2 additions & 2 deletions text/3383-recommended-bin-crates.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,11 @@ The developers of `foobar` suggest you may want to install `foobar-cli` instead.
# Reference-level explanation
[reference-level-explanation]: #reference-level-explanation

The `cargo-install` command has already parsed the `Cargo.toml` manifest
The `cargo install` command has already parsed the `Cargo.toml` manifest
file when it prints this error message, so it would simply have to
additionally check for this new field when printing the error message.

`cargo-publish` should assert that the referenced
`cargo publish` should assert that the referenced
crates already exist and have not been yanked.

# Drawbacks
Expand Down