Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when alias shadows external subcommand #10082

Merged
merged 6 commits into from
Nov 17, 2021
Merged

Warn when alias shadows external subcommand #10082

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5bfd345
Warn when alias shadows external subcommand
basile-henry Nov 14, 2021
9f768bb
Update test for warning for alias shadowing an external subcommand
basile-henry Nov 14, 2021
2ead2d9
Update tests/testsuite/cargo_alias_config.rs
basile-henry Nov 14, 2021
3a5bb75
Update tests/testsuite/cargo_alias_config.rs
basile-henry Nov 14, 2021
cba8503
Add details in warning for alias shadowing external subcommands
basile-henry Nov 17, 2021
0b4e2ca
Add test for alias shadowing external subcommand
basile-henry Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update tests/testsuite/cargo_alias_config.rs
  • Loading branch information
@basile-henry
basile-henry authored Nov 14, 2021
commit 2ead2d9e3dc829b82ea1017dd5374c8c76ea0615
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_alias_config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ fn default_args_alias() {
.env("PATH", &path)
.with_status(101)
.with_stderr("\
warning: user-defined alias `echo` is shadowing an external subcommand found at: `[ROOT]/cargo-echo/target/debug/cargo-echo`
warning: user-defined alias `echo` is shadowing an external subcommand found at: `[ROOT]/cargo-echo/target/debug/cargo-echo[EXE]`
error: alias echo has unresolvable recursive definition: echo -> echo
",
)
Expand Down