Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test: hash value depends on endianness and bitness. #10011

Merged
merged 3 commits into from
Nov 10, 2021
Merged

Fix test: hash value depends on endianness and bitness. #10011

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5590ca
Only run test on 64-bit little endian architectures.
hkratz Oct 25, 2021
d4c524e
Reword comment.
hkratz Nov 8, 2021
aa00def
fmt
hkratz Nov 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reword comment.
  • Loading branch information
@hkratz
hkratz authored Nov 8, 2021
commit d4c524e461f374e0df0549a6da8b1c445eaf3bb2
7 changes: 3 additions & 4 deletions src/cargo/core/source/source_id.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,10 +618,9 @@ impl Ord for SourceKind {
// Otherwise please just leave a comment in your PR as to why the hash value is
// changing and why the old value can't be easily preserved.
//
// The hash value differs depending on endianess and bit-width since Rust 1.45
// (see https://github.com/rust-lang/rust/issues/74215). We run this test only
// on 64-bit little-endian platforms which are most commonly used for
// development and tested in CI.
// The hash value depends on endianness and bit-width, so we only run this test on
// little-endian 64-bit CPUs (such as x86-64 and ARM64) where it matches the
// well-known value.
#[test]
#[cfg(all(target_endian = "little", target_pointer_width = "64"))]
fn test_cratesio_hash() {
Expand Down