minor main opt leak

rurban · Mar 31, 2021 · 7e01a4a · 7e01a4a
1 parent 0a516c7
commit 7e01a4a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -10,7 +10,6 @@ jobs:
         CMAKE_ARGS:
           - 
           - -DCMAKE_BUILD_TYPE=Debug
-          - -DCMAKE_BUILD_TYPE=Asan
           - -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_C_COMPILER=clang
     steps:
     - uses: actions/checkout@v2

diff --git a/main.cpp b/main.cpp
@@ -1815,12 +1815,15 @@ int main ( int argc, const char ** argv )
         char *rest = opt;
         char *p;
         bool found = false;
+        bool need_opt_free = false;
         g_testAll = false;
         do {
           if ((p = strchr(rest, ','))) {
             opt = strndup(rest, p-rest);
+            need_opt_free = true;
             rest = p+1;
           } else {
+            need_opt_free = false;
             opt = rest;
           }
           for (size_t i = 0; i < sizeof(g_testopts) / sizeof(TestOpts); i++) {
@@ -1835,8 +1838,12 @@ int main ( int argc, const char ** argv )
               printf(",%s", g_testopts[i].name);
             }
             printf(" \n");
+            if (need_opt_free)
+              free(opt);
             exit(1);
           }
+          if (need_opt_free)
+            free(opt);
         } while (p);
         continue;
       }