restartmanager: RestartManager.Cancel(): remove unused error return

This function would never return an error, and no code was handling errors. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
runpod · Dec 28, 2022 · d68b68f · d68b68f
1 parent 598c295
commit d68b68f
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/restartmanager/restartmanager.go b/restartmanager/restartmanager.go
@@ -21,7 +21,7 @@ var ErrRestartCanceled = errors.New("restart canceled")
 
 // RestartManager defines object that controls container restarting rules.
 type RestartManager interface {
-	Cancel() error
+	Cancel()
 	ShouldRestart(exitCode uint32, hasBeenManuallyStopped bool, executionDuration time.Duration) (bool, chan error, error)
 }
 
@@ -125,12 +125,11 @@ func (rm *restartManager) ShouldRestart(exitCode uint32, hasBeenManuallyStopped
 	return true, ch, nil
 }
 
-func (rm *restartManager) Cancel() error {
+func (rm *restartManager) Cancel() {
 	rm.Do(func() {
 		rm.Lock()
 		rm.canceled = true
 		close(rm.cancel)
 		rm.Unlock()
 	})
-	return nil
 }