Merge pull request moby#46722 from thaJeztah/dedup_additionalgroups

daemon: remove redundant withResetAdditionalGIDs option
runpod · Oct 25, 2023 · 4776a9e · 4776a9e
2 parents 460e1b3 + 4170186
commit 4776a9e
Showing 1 changed file with 0 additions and 9 deletions.
diff --git a/daemon/exec_linux.go b/daemon/exec_linux.go
@@ -4,7 +4,6 @@ import (
 	"context"
 
 	"github.com/containerd/containerd"
-	"github.com/containerd/containerd/containers"
 	"github.com/containerd/containerd/oci"
 	coci "github.com/containerd/containerd/oci"
 	"github.com/containerd/containerd/pkg/apparmor"
@@ -14,13 +13,6 @@ import (
 	specs "github.com/opencontainers/runtime-spec/specs-go"
 )
 
-func withResetAdditionalGIDs() oci.SpecOpts {
-	return func(_ context.Context, _ oci.Client, _ *containers.Container, s *oci.Spec) error {
-		s.Process.User.AdditionalGids = nil
-		return nil
-	}
-}
-
 func getUserFromContainerd(ctx context.Context, containerdCli *containerd.Client, ec *container.ExecConfig) (specs.User, error) {
 	ctr, err := containerdCli.LoadContainer(ctx, ec.Container.ID)
 	if err != nil {
@@ -39,7 +31,6 @@ func getUserFromContainerd(ctx context.Context, containerdCli *containerd.Client
 
 	opts := []oci.SpecOpts{
 		coci.WithUser(ec.User),
-		withResetAdditionalGIDs(),
 		coci.WithAdditionalGIDs(ec.User),
 		coci.WithAppendAdditionalGroups(ec.Container.HostConfig.GroupAdd...),
 	}