Merge pull request #1763 from clementchong/hotfix_1762

Added i18n to viz save confirmation dialog
running-elephant · Jul 28, 2022 · 4ab658a · 4ab658a
2 parents c6d0c6e + 1cf5426
commit 4ab658a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/frontend/src/app/components/ChartEditor.tsx b/frontend/src/app/components/ChartEditor.tsx
@@ -502,7 +502,7 @@ export const ChartEditor: FC<ChartEditorProps> = ({
       } else {
         // dataChart
         confirm({
-          title: '保存修改后不能撤销，确定继续保存吗？',
+          title: tg('button.saveConfirm'),
           icon: <ExclamationCircleOutlined />,
           async onOk() {
             dispatch(
@@ -540,6 +540,7 @@ export const ChartEditor: FC<ChartEditorProps> = ({
     chartConfig,
     dataview?.computedFields,
     history,
+    tg,
   ]);
 
   const saveChartToDashBoard = useCallback(

diff --git a/frontend/src/locales/en/translation.json b/frontend/src/locales/en/translation.json
@@ -20,7 +20,8 @@
       "saveAs": "Save As",
       "cancel": "Cancel",
       "ok": "OK",
-      "shortcuts": "Shortcuts"
+      "shortcuts": "Shortcuts",
+      "saveConfirm": "After saving the changes, it cannot be undone. Are you sure you want to continue saving?"
     },
     "operation": {
       "archiveConfirm": "Archive confirm",

diff --git a/frontend/src/locales/zh/translation.json b/frontend/src/locales/zh/translation.json
@@ -20,7 +20,8 @@
       "saveAs": "另存为",
       "cancel": "取消",
       "ok": "确定",
-      "shortcuts": "快捷键"
+      "shortcuts": "快捷键",
+      "saveConfirm": "保存修改后不能撤销，确定继续保存吗？"
     },
     "operation": {
       "archiveConfirm": "确定移至回收站？",