Replace putenv() with setenv()

The use of `putenv()` is discouraged for portability reasons: https://pubs.opengroup.org/onlinepubs/9799919799/functions/putenv.html
rui314 · Dec 25, 2024 · afd2fab · afd2fab
1 parent 26493c0
commit afd2fab
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/subprocess-unix.cc b/src/subprocess-unix.cc
@@ -101,8 +101,8 @@ void process_run_subcommand(Context<E> &ctx, int argc, char **argv) {
   std::string dso_path = find_dso(ctx, self);
 
   // Set environment variables
-  putenv(strdup(("LD_PRELOAD=" + dso_path).c_str()));
-  putenv(strdup(("MOLD_PATH=" + self).c_str()));
+  setenv("LD_PRELOAD", dso_path.c_str(), 1);
+  setenv("MOLD_PATH", self.c_str(), 1);
 
   // If ld, ld.lld or ld.gold is specified, run mold itself
   if (std::string cmd = path_filename(argv[2]);