Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade golangci-lint and config, address findings #258

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Upgrade golangci-lint and config, address findings #258

merged 4 commits into from
Jan 8, 2024

Conversation

scop
Copy link
Contributor

@scop scop commented Dec 20, 2023

No description provided.

@scop scop mentioned this pull request Dec 20, 2023
Open
@scop
Copy link
Contributor Author

scop commented Dec 20, 2023

@rubenv I've had #245 waiting for quite a while, this is a prerequisite for it (it provoked some unrelated linter warnings that I can tell). Could you have a look at this so I could rebase that one and we could nudge it forward?

@rubenv rubenv merged commit 4c7bdce into rubenv:master Jan 8, 2024
11 checks passed
@rubenv
Copy link
Owner

rubenv commented Jan 8, 2024

Merged, thanks! Sorry for the delay.

@scop scop deleted the chore/linting-update branch February 2, 2024 07:25
@scop
Copy link
Contributor Author

scop commented Feb 2, 2024

Thanks! #245 refreshed accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scop @rubenv