SWIG bindings: Support DownloadCallbacks user_data, unit tests
#1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow their use in tests.
Tests for PackageDownloader and repository download.
Tests repo::DownloadCallbacks in all supported languages.
We want to avoid violating ODR. We want to isolate the tests.
jrohel
force-pushed
the
swig_Repo_DownloadCallbacks_user_data
branch
from
5d345a1 to
561bfc2
Compare
|
Thank you. I would add some sort of documentation or perhaps tutorial example but that should be a separate PR. |
Merged
via the queue into
rpm-software-management:main
with commit Dec 10, 2024
51317ce
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1943
Adds support for the
user_dataargument to therepo::DownloadCallbacks::add_new_downloadmethod.Its value can be set for different downloaders:
repo::FileDownloader:user_datacan be passed as a parameter to theaddmethod for the file being added.repo::PackageDownloader:user_datacan be passed as a parameter to theaddmethod for the package being added.The
repo::Repo::set_user_dataandrepo::Repo::get_user_datamethods to set/getuser_datafor each repository - used when downloading repository metadata.Unit tests for all supported languages included.