-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
invert the display_next flag if user holds the shift modifier key while deleting a message #9356
base: master
Are you sure you want to change the base?
Conversation
It does not make sense to me. Shift key already has a meaning on delete. |
Ah, yes - I see. The shift key is used for a specific case where it's about deleting without moving to trash. I didn't notice this as it's clearly not my use case, I always have 'flag_for_deletion' active.
You probably don't use the mail list in the way I do. By keeping mail unread it's marked as 'open' with the meaning of 'not yet done'. Often I need to delete newer (server log) emails but keep the newest message unread. So either I'd have to turn display_next on, then I'd have to remember to every time manually set the newest message to unread again. Or I'd have to turn display_next off, then I'd have to manually go to the next server log email after deleting one of them. Both is not convenient. In horde, the behavior was exactly like it's with the patch now, which I like a lot as a very convenient solution. Maybe I could change this so that the new code is only active if 'flag_for_deletion' is active - would you like that better? |
If 'flag_for_deletion' is active 'display_next' does not apply as the message is not being removed from the list. So, it does not make much sense. In this mode you can just press That being said, maybe use |
@the0ne Are you still interested in this PR? If so, what about Alec's suggestion to use |
Definitely, yes. I'm using it as proposed, which works great. |
What meaning is that? |
As you've find out earlier it's "delete without moving to Trash". |
@alecpl thanks for the reminder - I don't know where I had my head. |
When deleting a message, usually I don't want to go to the next message, but sometimes I want to.
Other users might want to usually go to the next message, but sometimes they possibly don't want to.
With this small addition, this can be easily achieved: