Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invert the display_next flag if user holds the shift modifier key while deleting a message #9356

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

the0ne
Copy link

@the0ne the0ne commented Feb 15, 2024

When deleting a message, usually I don't want to go to the next message, but sometimes I want to.
Other users might want to usually go to the next message, but sometimes they possibly don't want to.

With this small addition, this can be easily achieved:

  1. Set your preference of "display_next" as usual.
  2. Whenever you want the opposite behaviour when deleting a mail, just hold the 'Shift' modifier key while doing so.

@alecpl
Copy link
Member

alecpl commented Feb 15, 2024

It does not make sense to me. Shift key already has a meaning on delete.

@the0ne
Copy link
Author

the0ne commented Feb 15, 2024

Shift key already has a meaning on delete.

Ah, yes - I see. The shift key is used for a specific case where it's about deleting without moving to trash. I didn't notice this as it's clearly not my use case, I always have 'flag_for_deletion' active.

It does not make sense to me.

You probably don't use the mail list in the way I do. By keeping mail unread it's marked as 'open' with the meaning of 'not yet done'. Often I need to delete newer (server log) emails but keep the newest message unread. So either I'd have to turn display_next on, then I'd have to remember to every time manually set the newest message to unread again. Or I'd have to turn display_next off, then I'd have to manually go to the next server log email after deleting one of them. Both is not convenient. In horde, the behavior was exactly like it's with the patch now, which I like a lot as a very convenient solution.

Maybe I could change this so that the new code is only active if 'flag_for_deletion' is active - would you like that better?

@alecpl
Copy link
Member

alecpl commented Mar 17, 2024

If 'flag_for_deletion' is active 'display_next' does not apply as the message is not being removed from the list. So, it does not make much sense. In this mode you can just press Del key and then Arrow-Down if you wish or not.

That being said, maybe use Ctrl key instead of Shift and we're good. I don't know. This may come in handy with #9357 if we decide it's a good idea.

Copy link

@pabzm, @alecpl
🛎️ This PR has had no activity in two weeks.

@pabzm
Copy link
Member

pabzm commented Nov 21, 2024

@the0ne Are you still interested in this PR? If so, what about Alec's suggestion to use Ctrl instead of Shift? If you're not interested anymore, please close.

@the0ne
Copy link
Author

the0ne commented Nov 21, 2024

Definitely, yes. I'm using it as proposed, which works great.

Copy link

github-actions bot commented Dec 6, 2024

@pabzm, @alecpl
🛎️ This PR has had no activity in two weeks.

@the0ne
Copy link
Author

the0ne commented Dec 6, 2024

It does not make sense to me. Shift key already has a meaning on delete.

What meaning is that?

@alecpl
Copy link
Member

alecpl commented Dec 6, 2024

As you've find out earlier it's "delete without moving to Trash".

@the0ne
Copy link
Author

the0ne commented Dec 6, 2024

@alecpl thanks for the reminder - I don't know where I had my head.
If you prefer to have this on [Ctrl] modifier key, of cause it would work for me as well 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants