[http] Accept headers whether or not preceded by request or response line. #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethsb
changed the title
garethsb
changed the title
tancnle
reviewed
Jul 10, 2022
Comment on lines
+35
to
+36
| ([^ ]+)(?:([ ]+) # path | ||
| (HTTPS?)(/)(\d(?:\.\d)?))?(\r?\n|$) # http version |
There was a problem hiding this comment.
suggestion: Spreading the regex across the two components make it a bit harder to read. Would it be possible to leave it as it is and remove the push :headers statement in both the request and response block?
What do you think about the following diff on master?
diff --git lib/rouge/lexers/http.rb lib/rouge/lexers/http.rb
index 8e4b0fbf..b28124a2 100644
--- lib/rouge/lexers/http.rb
+++ lib/rouge/lexers/http.rb
@@ -40,8 +40,6 @@ module Rouge
Name::Namespace, Text,
Keyword, Operator, Num, Text
)
-
- push :headers
end
# response
@@ -55,8 +53,9 @@ module Rouge
Num, Text,
Name::Exception, Text
)
- push :headers
end
+
+ mixin :headers
end
state :headers do
tancnle
added
the
author-action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1704