Added postgresql lexer. #1575
Open
Added postgresql lexer. #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrmont
suggested changes
Sep 8, 2020
There was a problem hiding this comment.
Thanks for submitting this and sorry it took a bit of time to get to it :(
I'm not very familiar with SQL but this looks like it's largely the same as the existing SQL lexer. I assume there are Postgres-specific syntax that this supports that isn't in the SQL lexer. Is that correct?
If that's the case, it would be better to subclass that lexer and then add anything you need that's extra. That way, bugs that get fixed in, or features that get added to, the SQL lexer will immediately benefit the Postgres lexer. Lexers that do this include the HQL lexer (which might be particularly relevant here) and the QML lexer.
pyrmont
added
author-action
|
Hello Michael,
The reason I didn't subclass the existing lexer is that there are keywords
there that aren't in PostgreSQL.
Also, the grammar will be different. Anonymous code blocks, Window
queries, Functions, etc.
Honestly, I'm not a strong Python programmer, so if you want me to go down
that road I'd need a bit of assistance to make the subclass.
Kirk Roybal
Principal Consultant
2ndQuadrant
…On Mon, 7 Sep 2020 at 20:36, Michael Camilleri ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Thanks for submitting this and sorry it took a bit of time to get to it :(
I'm not very familiar with SQL but this looks like it's largely the same
as the existing SQL lexer. I assume there are Postgres-specific syntax that
this supports that isn't in the SQL lexer. Is that correct?
If that's the case, it would be better to subclass that lexer and then add
anything you need that's extra. That way, bugs that get fixed in, or
features that get added to, the SQL lexer will immediately benefit the
Postgres lexer. Lexers that do this include the HQL lexer
<https://github.com/rouge-ruby/rouge/blob/6c9d1b7ca804ac80a9682cc8dbd416db0de38684/lib/rouge/lexers/hql.rb>
(which might be particularly relevant here) and the QML lexer
<https://github.com/rouge-ruby/rouge/blob/master/lib/rouge/lexers/qml.rb>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1575 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC3AFGZFEC2HBGQXLELCLLDSEWDDVANCNFSM4P47CVHQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes the small test and adds all the keywords for PostgreSQL. This fixes #1573.