Fix multiple load when running rougify -r ...
#1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
except through `reload!` which properly removes the previous version first
jneen
force-pushed
the
bugfix.multiple-load-warning
branch
from
b6390b9 to
05840b6
Compare
|
This is failing because ruby 2.3 and earlier do not support top-level However, we can solve the same problem by using a |
|
Er.... hang on no we can't. That would still allow multiple versions of Rouge to be loaded in the same runtime. |
pyrmont
reviewed
Sep 8, 2020
Comment on lines
+7
to
+9
| # Avoid multiple loads (top-level return will be possible when 2.4+ is the | ||
| # minimum supported version) | ||
| unless Object::const_defined?(:Rouge) && Rouge.const_defined?(:LIB_DIR) |
There was a problem hiding this comment.
@jneen According to these notes, this was the alternative approach before top-level return. What do you think?
There was a problem hiding this comment.
@jneen How does this look to you?
pyrmont
added
author-action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the required file contains
require 'rouge'(which should be unnecessary when usingrougifybut might be there for other purposes), we currently catastrophically load another copy of Rouge, which may be from a different version. This prevents that with a simple definition guard.I know it looks hacky, but it's the only way to have proper reload semantics.
Rouge.reload!continues to work with this, because theRougeconstant will be removed from the toplevel first.(edit: accidentally pushed the wrong branch, this is 1 commit)