Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Elixir lexer number rules #1015

Closed
wants to merge 1 commit into from
Closed

Improve Elixir lexer number rules #1015

wants to merge 1 commit into from

Conversation

thth
Copy link

@thth thth commented Oct 11, 2018 •
edited
Loading

  • separated the different types
  • added octal
  • other fixes (e.g. erroneously matching on capital X and B for hex and bin)

These rules were double-checked against the Elixir TextMate Bundle.

vidarh
vidarh suggested changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@vidarh vidarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I'm trying to help triage pull requests so we can work down the backlog. This looks good, but I notice there doesn't appear to be examples. Would you mind adding examples of the number types in spec/visual?

@pyrmont
Copy link
Contributor

pyrmont commented May 14, 2019

@vidarh Given the original source of the PR has apparently been deleted, I suspect @thth may not make any further changes. I might look at checking out the code in the PR and adding these examples myself.

@pyrmont pyrmont added the needs-review The PR needs to be reviewed label May 30, 2019
@pyrmont pyrmont mentioned this pull request Jun 26, 2019
Merged
@pyrmont
Copy link
Contributor

pyrmont commented Jun 26, 2019

The original branch has been deleted and so this has been resubmitted as #1225.

@pyrmont pyrmont closed this Jun 26, 2019
@pyrmont pyrmont removed the needs-review The PR needs to be reviewed label Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vidarh vidarh vidarh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thth @pyrmont @vidarh