Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Similarity tester to fail builds #1230

Closed
pyrmont opened this issue Jun 29, 2019 · 4 comments
Closed

Use Similarity tester to fail builds #1230

pyrmont opened this issue Jun 29, 2019 · 4 comments
Labels
enhancement-request A request for an enhancement to be developed. stale-issue There has been no activity for a year.

Comments

@pyrmont
Copy link
Contributor

pyrmont commented Jun 29, 2019

Is your enhancement request related to a problem? Please describe.
Sometimes lexers that are submitted are created by copying and pasting existing lexers. While this is not a bad way to begin development, a lexer should not be sufficiently differentiated from existing lexers. In #1206, @jneen added a mechanism to test the similarity of lexers.

Describe the solution you'd like
As part of Travis' build process, it would test the similarity of the lexer that was being added/modified to existing lexers.
@pyrmont pyrmont added the enhancement-request A request for an enhancement to be developed. label Jun 29, 2019
@stale
Copy link

stale bot commented Jun 28, 2020

This issue has been automatically marked as stale because it has not had any activity for more than a year. It will be closed if no additional activity occurs within the next 14 days.
If you would like this issue to remain open, please reply and let us know if the issue is still reproducible.

@stale stale bot added the stale-issue There has been no activity for a year. label Jun 28, 2020
@pyrmont
Copy link
Contributor Author

pyrmont commented Jun 29, 2020

@jneen Do you think this is a good idea? I've gone lukewarm on it now. I like that we can test Similarity but failing a build seems too extreme. I'm of a mind to close this issue. What do you think?

@stale stale bot removed the stale-issue There has been no activity for a year. label Jun 29, 2020
@jneen
Copy link
Member

jneen commented Jun 29, 2020

I think it should at least put a warning on the pull request - if there's a way to do this without failing the whole build then that'd be lovely.

@stale
Copy link

stale bot commented Jun 30, 2021

This issue has been automatically marked as stale because it has not had any activity for more than a year. It will be closed if no additional activity occurs within the next 14 days.
If you would like this issue to remain open, please reply and let us know if the issue is still reproducible.

@stale stale bot added the stale-issue There has been no activity for a year. label Jun 30, 2021
@stale stale bot closed this as completed Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement-request A request for an enhancement to be developed. stale-issue There has been no activity for a year.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pyrmont @jneen