JSX: Allow dashes in attribute names (#1650)

Support attributes with names that contain dashes, e.g. ARIA attributes.
rouge-ruby · Jan 26, 2022 · 8229933 · 8229933
1 parent c91b3a7
commit 8229933
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/lib/rouge/lexers/jsx.rb b/lib/rouge/lexers/jsx.rb
@@ -57,7 +57,7 @@ class JSX < Javascript
           push :interpol
           push :expr_start
         end
-        rule %r/\w+/, Name::Attribute
+        rule %r/\w[\w-]*/, Name::Attribute
         rule %r/=/, Punctuation
         rule %r/(["']).*?(\1)/, Str
       end

diff --git a/spec/lexers/jsx_spec.rb b/spec/lexers/jsx_spec.rb
@@ -15,5 +15,20 @@
       assert_guess :mimetype => 'application/x-jsx'
     end
   end
+
+  describe 'lexing' do
+    include Support::Lexing
+
+    it 'parse attribute with dashes' do
+      assert_tokens_equal '<button aria-label="hello"/>',
+        ['Punctuation', '<'],
+        ['Name.Tag', 'button'],
+        ['Text', ' '],
+        ['Name.Attribute', 'aria-label'],
+        ['Punctuation', '='],
+        ['Literal.String', '"hello"'],
+        ['Punctuation', '/>']
+    end
+  end
 end