Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

🐛 noDuplicateCase false positive on quotes #4706

Closed
1 task done
JP250552 opened this issue Jul 18, 2023 · 1 comment · Fixed by #4709
Closed
1 task done

🐛 noDuplicateCase false positive on quotes #4706

JP250552 opened this issue Jul 18, 2023 · 1 comment · Fixed by #4709
Assignees
@Conaclos
Labels
A-Linter Area: linter S-Bug: confirmed Status: report has been confirmed as a valid bug

Comments

@JP250552
Copy link

Environment information

CLI:
  Version:                      12.1.3-nightly.f65b0d9
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  ROME_LOG_DIR:                 unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v18.16.1"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "yarn/3.6.1"

Rome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    true
  VCS disabled:                 false

Workspace:
  Open Documents:               0

Discovering running Rome servers...

Incompatible Rome Server: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

ℹ Rage discovered this running server using an incompatible version of Rome.

Server:
  Version:                      12.1.3

What happened?

When using a switch statement with cases for both single quotes (') and double quotes ("), a lint/suspicious/noDuplicateCase is being thrown even though it is a valid scenario.

Playground

Expected result

It should not throw an error

Code of Conduct

  • I agree to follow Rome's Code of Conduct
@JP250552 JP250552 added the S-To triage Status: user report of a possible bug that needs to be triaged label Jul 18, 2023
@JP250552 JP250552 changed the title 🐛 noDuplicateCase false positive with quotes 🐛 noDuplicateCase false positive on quotes Jul 18, 2023
@ematipico ematipico added S-Bug: confirmed Status: report has been confirmed as a valid bug A-Linter Area: linter and removed S-To triage Status: user report of a possible bug that needs to be triaged labels Jul 18, 2023
@Conaclos Conaclos self-assigned this Jul 18, 2023
@Conaclos Conaclos mentioned this issue Jul 18, 2023
Merged
@JP250552
Copy link
Author

Thanks for the quick turnaround!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Conaclos Conaclos

Labels
A-Linter Area: linter S-Bug: confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(rome_js_analyze): fix a false positive for noDuplicateCase
3 participants
@ematipico @Conaclos @JP250552