Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

🐛 mulitple symlinks pointing to the same file mistaken as "Infinite symlink expansion" #4395

Open
1 task done
toxeus opened this issue Apr 20, 2023 · 2 comments
Open
1 task done

🐛 mulitple symlinks pointing to the same file mistaken as "Infinite symlink expansion" #4395

toxeus opened this issue Apr 20, 2023 · 2 comments
Labels
S-To triage Status: user report of a possible bug that needs to be triaged

Comments

@toxeus
Copy link

toxeus commented Apr 20, 2023

Environment information

CLI:
  Version:                      12.0.0
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           linux

Environment:
  ROME_LOG_DIR:                 unset
  NO_COLOR:                     unset
  TERM:                         "xterm"
  JS_RUNTIME_VERSION:           "v19.9.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "yarn/1.22.19"

Rome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    true

Workspace:
  Open Documents:               0

What happened?

mkdir -p a/b/{c,d}
touch a/foo.html
ln -s ../../foo.html a/b/c/foo.html
# without the next line everything works fine
ln -s ../../foo.html a/b/d/foo.html
# rome ci fails
yarn run rome ci ./a

Expected result

It should not fail.

Code of Conduct

  • I agree to follow Rome's Code of Conduct
@toxeus toxeus added the S-To triage Status: user report of a possible bug that needs to be triaged label Apr 20, 2023
@toxeus
Copy link
Author

toxeus commented Apr 20, 2023

related: #4193, #4221

@arendjr
Copy link
Contributor

arendjr commented Jul 24, 2023

I also just ran into this issue using Rome 12.1.3. Adding the symlinked files to the list of ignored files in the config also doesn't help anymore once there are multiple links to the same file.

This was referenced Jul 24, 2023
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
S-To triage Status: user report of a possible bug that needs to be triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arendjr @toxeus