Fix warning messages #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellscape
approved these changes
Mar 7, 2020
|
Please fix the CI errors so we can merge this. |
|
Sorry, this one is on me. npm audit failure. |
|
@petabyteboy please include tests next time you contribute to a rollup project. I was moving too quick today to see that you had checked the box but did not include tests. That's not cool. |
shellscape
added a commit
that referenced
this pull request
Mar 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Solves #4
I have verified locally that this prevents the warning messages that came up when adding plugins like node-resolve or commonjs to the examples.