Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Gulp watch documentation #3

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Conversation

Dan503
Copy link
Contributor

@Dan503 Dan503 commented Dec 27, 2019

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers: #1

Description

This pull request adds documentation to guide users on how to most effectively use @rollup/stream in a Gulp watch task.

I also removed import terser from 'gulp-terser'; from the source-maps example since it wasn't being used in the example and it might confuse people.

I also converted the rollup-stream readme link to a cleaner text based link rather than a url.

@shellscape
Copy link
Contributor

Sorry it took a while to get eyes on this. We've been full steam ahead on the plugins repo and I had admittedly forgotten to watch this repo.

@shellscape shellscape merged commit 206f967 into rollup:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants