The latest updates on your projects. Learn more about Vercel for Git ↗︎

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#original-file-names-array

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-prhuuggl2-rollup-js.vercel.app/repl/?pr=5686

Performance report!

Rough benchmark

Internal benchmark

• BUILD: 8266ms, 751 MB
  • initialize: 0ms, 26.1 MB
  • generate module graph: 3177ms, 575 MB
    • generate ast: 1556ms (+42ms, +2.8%), 568 MB
  • sort and bind modules: 455ms, 618 MB
  • mark included statements: 4631ms, 751 MB
    • treeshaking pass 1: 1574ms, 717 MB
    • treeshaking pass 2: 756ms, 740 MB
    • treeshaking pass 3: 296ms, 746 MB
    • treeshaking pass 4: 274ms, 746 MB
    • treeshaking pass 5: 320ms, 750 MB
    • treeshaking pass 6: 263ms, 751 MB
    • treeshaking pass 7: 246ms, 751 MB
    • treeshaking pass 8: 238ms, 754 MB
    • treeshaking pass 9: 217ms, 755 MB
    • treeshaking pass 10: 219ms, 755 MB
    • treeshaking pass 11: 217ms, 751 MB
• GENERATE: 894ms, 1.02 GB
  • initialize render: 0ms, 914 MB
  • generate chunks: 86ms, 920 MB
    • optimize chunks: 0ms, 918 MB
  • render chunks: 786ms, 1 GB
  • transform chunks: 21ms, 1.02 GB
  • generate bundle: 0ms, 1.02 GB

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.05%. Comparing base (bc7780c) to head (3deae08).
Report is 1 commits behind head on master.

@@           Coverage Diff           @@
##           master    #5686   +/-   ##
=======================================
  Coverage   99.04%   99.05%           
=======================================
  Files         242      242           
  Lines        9352     9387   +35     
  Branches     2473     2482    +9     
=======================================
+ Hits         9263     9298   +35     
  Misses         58       58           
  Partials       31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Thanks! I tried this PR at vitejs/vite#18240. It works for Vite's case 👍

This PR has been released as part of rollup@4.23.0. You can test it via npm install rollup.

Hey @lukastaegert, how does the migration looks like from name to names, before i was using something like this

example:

    assetFileNames({ name }) {
        const p = "[name][extname]";

        if (!name) {
            return p;
        }

        if (name.endsWith(".css")) {
            return `css/${p}`;
        }

        if (name.endsWith(".map")) {
            return `map/${p}`;
        }

        return p;
    },

with names do i need only to check for the first entry, or do i need to check all entries in names?

Technically you would need to check all entries, though it will be one entry most of the time anyway. I usually would not expect the extensions to differ if the content is the same, and there is probably no reason to pick any but the first name if your just need a name and do not want to compare it to anything.