Support JSXSpreadChild

rollup · lukastaegert · Oct 2, 2024 · Mar 1, 2024 · Mar 2, 2024 · Mar 2, 2024
commit c240f3f763f796cc421ecd799e53cf19d5070947
diff --git a/rust/parse_ast/src/convert_ast/converter.rs b/rust/parse_ast/src/convert_ast/converter.rs
@@ -4,9 +4,9 @@ use swc_ecma_ast::{
   ExprOrSpread, ForHead, ImportSpecifier, JSXAttr, JSXAttrName, JSXAttrOrSpread, JSXAttrValue,
   JSXClosingElement, JSXClosingFragment, JSXElement, JSXElementChild, JSXElementName, JSXEmptyExpr,
   JSXExpr, JSXExprContainer, JSXFragment, JSXMemberExpr, JSXNamespacedName, JSXObject,
-  JSXOpeningElement, JSXOpeningFragment, JSXText, Lit, ModuleDecl, ModuleExportName, ModuleItem,
-  NamedExport, ObjectPatProp, OptChainBase, ParenExpr, Pat, Program, PropName, PropOrSpread,
-  SimpleAssignTarget, Stmt, VarDeclOrExpr,
+  JSXOpeningElement, JSXOpeningFragment, JSXSpreadChild, JSXText, Lit, ModuleDecl,
+  ModuleExportName, ModuleItem, NamedExport, ObjectPatProp, OptChainBase, ParenExpr, Pat, Program,
+  PropName, PropOrSpread, SimpleAssignTarget, Stmt, VarDeclOrExpr,
 };
 
 use crate::ast_nodes::call_expression::StoredCallee;
@@ -26,13 +26,14 @@ use crate::convert_ast::converter::ast_constants::{
   JSX_NAMESPACED_NAME_NAME_OFFSET, JSX_NAMESPACED_NAME_NAMESPACE_OFFSET,
   JSX_NAMESPACED_NAME_RESERVED_BYTES, JSX_OPENING_ELEMENT_ATTRIBUTES_OFFSET,
   JSX_OPENING_ELEMENT_NAME_OFFSET, JSX_OPENING_ELEMENT_RESERVED_BYTES,
-  JSX_OPENING_FRAGMENT_RESERVED_BYTES, JSX_TEXT_RAW_OFFSET, JSX_TEXT_RESERVED_BYTES,
+  JSX_OPENING_FRAGMENT_RESERVED_BYTES, JSX_SPREAD_CHILD_EXPRESSION_OFFSET,
+  JSX_SPREAD_CHILD_RESERVED_BYTES, JSX_TEXT_RAW_OFFSET, JSX_TEXT_RESERVED_BYTES,
   JSX_TEXT_VALUE_OFFSET, TYPE_CLASS_EXPRESSION, TYPE_FUNCTION_DECLARATION,
   TYPE_FUNCTION_EXPRESSION, TYPE_JSX_ATTRIBUTE, TYPE_JSX_CLOSING_ELEMENT,
   TYPE_JSX_CLOSING_FRAGMENT, TYPE_JSX_ELEMENT, TYPE_JSX_EMPTY_EXPRESSION,
   TYPE_JSX_EXPRESSION_CONTAINER, TYPE_JSX_FRAGMENT, TYPE_JSX_IDENTIFIER,
   TYPE_JSX_MEMBER_EXPRESSION, TYPE_JSX_NAMESPACED_NAME, TYPE_JSX_OPENING_ELEMENT,
-  TYPE_JSX_OPENING_FRAGMENT, TYPE_JSX_TEXT,
+  TYPE_JSX_OPENING_FRAGMENT, TYPE_JSX_SPREAD_CHILD, TYPE_JSX_TEXT,
 };
 use crate::convert_ast::converter::string_constants::{
   STRING_NOSIDEEFFECTS, STRING_PURE, STRING_SOURCEMAP,
@@ -479,8 +480,8 @@ impl<'a> AstConverter<'a> {
       JSXElementChild::JSXExprContainer(jsx_expr_container) => {
         self.convert_jsx_expression_container(jsx_expr_container);
       }
-      JSXElementChild::JSXSpreadChild(_jsx_spread_child) => {
-        unimplemented!("JSXElementChild::JSXSpreadChild")
+      JSXElementChild::JSXSpreadChild(jsx_spread_child) => {
+        self.convert_jsx_spread_child(jsx_spread_child);
       }
       JSXElementChild::JSXFragment(jsx_fragment) => {
         self.convert_jsx_fragment(jsx_fragment);
@@ -983,6 +984,20 @@ impl<'a> AstConverter<'a> {
     self.add_end(end_position, &jsxopening_fragment.span);
   }
 
+  fn convert_jsx_spread_child(&mut self, jsx_spread_child: &JSXSpreadChild) {
+    let end_position = self.add_type_and_start(
+      &TYPE_JSX_SPREAD_CHILD,
+      &jsx_spread_child.span,
+      JSX_SPREAD_CHILD_RESERVED_BYTES,
+      false,
+    );
+    // expression
+    self.update_reference_position(end_position + JSX_SPREAD_CHILD_EXPRESSION_OFFSET);
+    self.convert_expression(&jsx_spread_child.expr);
+    // end
+    self.add_end(end_position, &jsx_spread_child.span);
+  }
+
   fn convert_jsx_text(&mut self, jsx_text: &JSXText) {
     let end_position = self.add_type_and_start(
       &TYPE_JSX_TEXT,

diff --git a/rust/parse_ast/src/convert_ast/converter/ast_constants.rs b/rust/parse_ast/src/convert_ast/converter/ast_constants.rs
@@ -36,21 +36,22 @@ pub const TYPE_JSX_MEMBER_EXPRESSION: [u8; 4] = 50u32.to_ne_bytes();
 pub const TYPE_JSX_NAMESPACED_NAME: [u8; 4] = 51u32.to_ne_bytes();
 pub const TYPE_JSX_OPENING_ELEMENT: [u8; 4] = 52u32.to_ne_bytes();
 pub const TYPE_JSX_OPENING_FRAGMENT: [u8; 4] = 53u32.to_ne_bytes();
-pub const TYPE_JSX_TEXT: [u8; 4] = 54u32.to_ne_bytes();
-pub const TYPE_LOGICAL_EXPRESSION: [u8; 4] = 62u32.to_ne_bytes();
-pub const TYPE_MEMBER_EXPRESSION: [u8; 4] = 63u32.to_ne_bytes();
-pub const TYPE_META_PROPERTY: [u8; 4] = 64u32.to_ne_bytes();
-pub const TYPE_METHOD_DEFINITION: [u8; 4] = 65u32.to_ne_bytes();
-pub const TYPE_NEW_EXPRESSION: [u8; 4] = 66u32.to_ne_bytes();
-pub const TYPE_PROGRAM: [u8; 4] = 70u32.to_ne_bytes();
-pub const TYPE_PROPERTY: [u8; 4] = 71u32.to_ne_bytes();
-pub const TYPE_PROPERTY_DEFINITION: [u8; 4] = 72u32.to_ne_bytes();
-pub const TYPE_REST_ELEMENT: [u8; 4] = 73u32.to_ne_bytes();
-pub const TYPE_SPREAD_ELEMENT: [u8; 4] = 76u32.to_ne_bytes();
-pub const TYPE_TEMPLATE_LITERAL: [u8; 4] = 83u32.to_ne_bytes();
-pub const TYPE_TRY_STATEMENT: [u8; 4] = 86u32.to_ne_bytes();
-pub const TYPE_VARIABLE_DECLARATION: [u8; 4] = 89u32.to_ne_bytes();
-pub const TYPE_VARIABLE_DECLARATOR: [u8; 4] = 90u32.to_ne_bytes();
+pub const TYPE_JSX_SPREAD_CHILD: [u8; 4] = 54u32.to_ne_bytes();
+pub const TYPE_JSX_TEXT: [u8; 4] = 55u32.to_ne_bytes();
+pub const TYPE_LOGICAL_EXPRESSION: [u8; 4] = 63u32.to_ne_bytes();
+pub const TYPE_MEMBER_EXPRESSION: [u8; 4] = 64u32.to_ne_bytes();
+pub const TYPE_META_PROPERTY: [u8; 4] = 65u32.to_ne_bytes();
+pub const TYPE_METHOD_DEFINITION: [u8; 4] = 66u32.to_ne_bytes();
+pub const TYPE_NEW_EXPRESSION: [u8; 4] = 67u32.to_ne_bytes();
+pub const TYPE_PROGRAM: [u8; 4] = 71u32.to_ne_bytes();
+pub const TYPE_PROPERTY: [u8; 4] = 72u32.to_ne_bytes();
+pub const TYPE_PROPERTY_DEFINITION: [u8; 4] = 73u32.to_ne_bytes();
+pub const TYPE_REST_ELEMENT: [u8; 4] = 74u32.to_ne_bytes();
+pub const TYPE_SPREAD_ELEMENT: [u8; 4] = 77u32.to_ne_bytes();
+pub const TYPE_TEMPLATE_LITERAL: [u8; 4] = 84u32.to_ne_bytes();
+pub const TYPE_TRY_STATEMENT: [u8; 4] = 87u32.to_ne_bytes();
+pub const TYPE_VARIABLE_DECLARATION: [u8; 4] = 90u32.to_ne_bytes();
+pub const TYPE_VARIABLE_DECLARATOR: [u8; 4] = 91u32.to_ne_bytes();
 
 pub const PANIC_ERROR_RESERVED_BYTES: usize = 8;
 pub const PANIC_ERROR_MESSAGE_OFFSET: usize = 4;
@@ -179,6 +180,9 @@ pub const JSX_OPENING_ELEMENT_ATTRIBUTES_OFFSET: usize = 12;
 
 pub const JSX_OPENING_FRAGMENT_RESERVED_BYTES: usize = 4;
 
+pub const JSX_SPREAD_CHILD_RESERVED_BYTES: usize = 8;
+pub const JSX_SPREAD_CHILD_EXPRESSION_OFFSET: usize = 4;
+
 pub const JSX_TEXT_RESERVED_BYTES: usize = 12;
 pub const JSX_TEXT_VALUE_OFFSET: usize = 4;
 pub const JSX_TEXT_RAW_OFFSET: usize = 8;

diff --git a/rust/parse_ast/src/convert_ast/converter/ast_macros.rs b/rust/parse_ast/src/convert_ast/converter/ast_macros.rs
@@ -319,7 +319,7 @@ macro_rules! store_import_specifier {
 macro_rules! store_labeled_statement {
   ($self:expr, span => $span:expr, label => [$label_value:expr, $label_converter:ident], body => [$body_value:expr, $body_converter:ident]) => {
     let _: &mut AstConverter = $self;
-    let end_position = $self.add_type_and_start(&55u32.to_ne_bytes(), &$span, 12, false);
+    let end_position = $self.add_type_and_start(&56u32.to_ne_bytes(), &$span, 12, false);
     // label
     $self.update_reference_position(end_position + 4);
     $self.$label_converter(&$label_value);
@@ -335,7 +335,7 @@ macro_rules! store_labeled_statement {
 macro_rules! store_literal_big_int {
   ($self:expr, span => $span:expr, bigint => $bigint_value:expr, raw => $raw_value:expr) => {
     let _: &mut AstConverter = $self;
-    let end_position = $self.add_type_and_start(&56u32.to_ne_bytes(), &$span, 12, false);
+    let end_position = $self.add_type_and_start(&57u32.to_ne_bytes(), &$span, 12, false);
     // bigint
     $self.convert_string($bigint_value, end_position + 4);
     // raw
@@ -350,7 +350,7 @@ macro_rules! store_literal_boolean {
   ($self:expr, span => $span:expr, value => $value_value:expr) => {
     let _: &mut AstConverter = $self;
     let end_position = $self.add_type_and_start(
-      &57u32.to_ne_bytes(),
+      &58u32.to_ne_bytes(),
       &$span,
       8,
       false,
@@ -366,7 +366,7 @@ macro_rules! store_literal_boolean {
 macro_rules! store_literal_null {
   ($self:expr, span => $span:expr) => {
     let _: &mut AstConverter = $self;
-    let end_position = $self.add_type_and_start(&58u32.to_ne_bytes(), &$span, 4, false);
+    let end_position = $self.add_type_and_start(&59u32.to_ne_bytes(), &$span, 4, false);
     // end
     $self.add_end(end_position, &$span);
   };
@@ -376,7 +376,7 @@ macro_rules! store_literal_null {
 macro_rules! store_literal_number {
   ($self:expr, span => $span:expr, raw => $raw_value:expr, value => $value_value:expr) => {
     let _: &mut AstConverter = $self;
-    let end_position = $self.add_type_and_start(&59u32.to_ne_bytes(), &$span, 16, false);
+    let end_position = $self.add_type_and_start(&60u32.to_ne_bytes(), &$span, 16, false);
     // raw
     if let Some(value) = $raw_value.as_ref() {
       $self.convert_string(value, end_position + 4);
@@ -393,7 +393,7 @@ macro_rules! store_literal_number {
 macro_rules! store_literal_reg_exp {
   ($self:expr, span => $span:expr, flags => $flags_value:expr, pattern => $pattern_value:expr) => {
     let _: &mut AstConverter = $self;
-    let end_position = $self.add_type_and_start(&60u32.to_ne_bytes(), &$span, 12, false);
+    let end_position = $self.add_type_and_start(&61u32.to_ne_bytes(), &$span, 12, false);
     // flags
     $self.convert_string($flags_value, end_position + 4);
     // pattern
@@ -407,7 +407,7 @@ macro_rules! store_literal_reg_exp {
 macro_rules! store_literal_string {
   ($self:expr, span => $span:expr, value => $value_value:expr, raw => $raw_value:expr) => {
     let _: &mut AstConverter = $self;
-    let end_position = $self.add_type_and_start(&61u32.to_ne_bytes(), &$span, 12, false);
+    let end_position = $self.add_type_and_start(&62u32.to_ne_bytes(), &$span, 12, false);
     // value
     $self.convert_string($value_value, end_position + 4);
     // raw
@@ -423,7 +423,7 @@ macro_rules! store_literal_string {
 macro_rules! store_object_expression {
   ($self:expr, span => $span:expr, properties => [$properties_value:expr, $properties_converter:ident]) => {
     let _: &mut AstConverter = $self;
-    let end_position = $self.add_type_and_start(&67u32.to_ne_bytes(), &$span, 8, false);
+    let end_position = $self.add_type_and_start(&68u32.to_ne_bytes(), &$span, 8, false);
     // properties
     $self.convert_item_list(
       &$properties_value,
@@ -442,7 +442,7 @@ macro_rules! store_object_expression {
 macro_rules! store_object_pattern {
   ($self:expr, span => $span:expr, properties => [$properties_value:expr, $properties_converter:ident]) => {
     let _: &mut AstConverter = $self;
-    let end_position = $self.add_type_and_start(&68u32.to_ne_bytes(), &$span, 8, false);
+    let end_position = $self.add_type_and_start(&69u32.to_ne_bytes(), &$span, 8, false);
     // properties
     $self.convert_item_list(
       &$properties_value,
@@ -461,7 +461,7 @@ macro_rules! store_object_pattern {
 macro_rules! store_private_identifier {
   ($self:expr, span => $span:expr, name => $name_value:expr) => {
     let _: &mut AstConverter = $self;
-    let end_position = $self.add_type_and_start(&69u32.to_ne_bytes(), &$span, 8, false);
+    let end_position = $self.add_type_and_start(&70u32.to_ne_bytes(), &$span, 8, false);
     // name
     $self.convert_string($name_value, end_position + 4);
     // end
@@ -473,7 +473,7 @@ macro_rules! store_private_identifier {
 macro_rules! store_return_statement {
   ($self:expr, span => $span:expr, argument => [$argument_value:expr, $argument_converter:ident]) => {
     let _: &mut AstConverter = $self;
-    let end_position = $self.add_type_and_start(&74u32.to_ne_bytes(), &$span, 8, false);
+    let end_position = $self.add_type_and_start(&75u32.to_ne_bytes(), &$span, 8, false);
     // argument
     if let Some(value) = $argument_value.as_ref() {
       $self.update_reference_position(end_position + 4);
@@ -488,7 +488,7 @@ macro_rules! store_return_statement {
 macro_rules! store_sequence_expression {
   ($self:expr, span => $span:expr, expressions => [$expressions_value:expr, $expressions_converter:ident]) => {
     let _: &mut AstConverter = $self;
-    let end_position = $self.add_type_and_start(&75u32.to_ne_bytes(), &$span, 8, false);
+    let end_position = $self.add_type_and_start(&76u32.to_ne_bytes(), &$span, 8, false);
     // expressions
     $self.convert_item_list(
       &$expressions_value,
@@ -507,7 +507,7 @@ macro_rules! store_sequence_expression {
 macro_rules! store_static_block {
   ($self:expr, span => $span:expr, body => [$body_value:expr, $body_converter:ident]) => {
     let _: &mut AstConverter = $self;
-    let end_position = $self.add_type_and_start(&77u32.to_ne_bytes(), &$span, 8, false);
+    let end_position = $self.add_type_and_start(&78u32.to_ne_bytes(), &$span, 8, false);
     // body
     $self.convert_item_list(&$body_value, end_position + 4, |ast_converter, node| {
       ast_converter.$body_converter(node);
@@ -522,7 +522,7 @@ macro_rules! store_static_block {
 macro_rules! store_super_element {
   ($self:expr, span => $span:expr) => {
     let _: &mut AstConverter = $self;
-    let end_position = $self.add_type_and_start(&78u32.to_ne_bytes(), &$span, 4, false);
+    let end_position = $self.add_type_and_start(&79u32.to_ne_bytes(), &$span, 4, false);
     // end
     $self.add_end(end_position, &$span);
   };
@@ -532,7 +532,7 @@ macro_rules! store_super_element {
 macro_rules! store_switch_case {
   ($self:expr, span => $span:expr, test => [$test_value:expr, $test_converter:ident], consequent => [$consequent_value:expr, $consequent_converter:ident]) => {
     let _: &mut AstConverter = $self;
-    let end_position = $self.add_type_and_start(&79u32.to_ne_bytes(), &$span, 12, false);
+    let end_position = $self.add_type_and_start(&80u32.to_ne_bytes(), &$span, 12, false);
     // test
     if let Some(value) = $test_value.as_ref() {
       $self.update_reference_position(end_position + 4);
@@ -556,7 +556,7 @@ macro_rules! store_switch_case {
 macro_rules! store_switch_statement {
   ($self:expr, span => $span:expr, discriminant => [$discriminant_value:expr, $discriminant_converter:ident], cases => [$cases_value:expr, $cases_converter:ident]) => {
     let _: &mut AstConverter = $self;
-    let end_position = $self.add_type_and_start(&80u32.to_ne_bytes(), &$span, 12, false);
+    let end_position = $self.add_type_and_start(&81u32.to_ne_bytes(), &$span, 12, false);
     // discriminant
     $self.update_reference_position(end_position + 4);
     $self.$discriminant_converter(&$discriminant_value);
@@ -574,7 +574,7 @@ macro_rules! store_switch_statement {
 macro_rules! store_tagged_template_expression {
   ($self:expr, span => $span:expr, tag => [$tag_value:expr, $tag_converter:ident], quasi => [$quasi_value:expr, $quasi_converter:ident]) => {
     let _: &mut AstConverter = $self;
-    let end_position = $self.add_type_and_start(&81u32.to_ne_bytes(), &$span, 12, false);
+    let end_position = $self.add_type_and_start(&82u32.to_ne_bytes(), &$span, 12, false);
     // tag
     $self.update_reference_position(end_position + 4);
     $self.$tag_converter(&$tag_value);
@@ -591,7 +591,7 @@ macro_rules! store_template_element {
   ($self:expr, span => $span:expr, tail => $tail_value:expr, cooked => $cooked_value:expr, raw => $raw_value:expr) => {
     let _: &mut AstConverter = $self;
     let end_position = $self.add_type_and_start(
-      &82u32.to_ne_bytes(),
+      &83u32.to_ne_bytes(),
       &$span,
       16,
       false,
@@ -613,7 +613,7 @@ macro_rules! store_template_element {
 macro_rules! store_this_expression {
   ($self:expr, span => $span:expr) => {
     let _: &mut AstConverter = $self;
-    let end_position = $self.add_type_and_start(&84u32.to_ne_bytes(), &$span, 4, false);
+    let end_position = $self.add_type_and_start(&85u32.to_ne_bytes(), &$span, 4, false);
     // end
     $self.add_end(end_position, &$span);
   };
@@ -623,7 +623,7 @@ macro_rules! store_this_expression {
 macro_rules! store_throw_statement {
   ($self:expr, span => $span:expr, argument => [$argument_value:expr, $argument_converter:ident]) => {
     let _: &mut AstConverter = $self;
-    let end_position = $self.add_type_and_start(&85u32.to_ne_bytes(), &$span, 8, false);
+    let end_position = $self.add_type_and_start(&86u32.to_ne_bytes(), &$span, 8, false);
     // argument
     $self.update_reference_position(end_position + 4);
     $self.$argument_converter(&$argument_value);
@@ -636,7 +636,7 @@ macro_rules! store_throw_statement {
 macro_rules! store_unary_expression {
   ($self:expr, span => $span:expr, operator => $operator_value:expr, argument => [$argument_value:expr, $argument_converter:ident]) => {
     let _: &mut AstConverter = $self;
-    let end_position = $self.add_type_and_start(&87u32.to_ne_bytes(), &$span, 12, false);
+    let end_position = $self.add_type_and_start(&88u32.to_ne_bytes(), &$span, 12, false);
     // operator
     let operator_position = end_position + 4;
     $self.buffer[operator_position..operator_position + 4].copy_from_slice($operator_value);
@@ -653,7 +653,7 @@ macro_rules! store_update_expression {
   ($self:expr, span => $span:expr, prefix => $prefix_value:expr, operator => $operator_value:expr, argument => [$argument_value:expr, $argument_converter:ident]) => {
     let _: &mut AstConverter = $self;
     let end_position = $self.add_type_and_start(
-      &88u32.to_ne_bytes(),
+      &89u32.to_ne_bytes(),
       &$span,
       16,
       false,
@@ -675,7 +675,7 @@ macro_rules! store_update_expression {
 macro_rules! store_while_statement {
   ($self:expr, span => $span:expr, test => [$test_value:expr, $test_converter:ident], body => [$body_value:expr, $body_converter:ident]) => {
     let _: &mut AstConverter = $self;
-    let end_position = $self.add_type_and_start(&91u32.to_ne_bytes(), &$span, 12, false);
+    let end_position = $self.add_type_and_start(&92u32.to_ne_bytes(), &$span, 12, false);
     // test
     $self.update_reference_position(end_position + 4);
     $self.$test_converter(&$test_value);
@@ -692,7 +692,7 @@ macro_rules! store_yield_expression {
   ($self:expr, span => $span:expr, delegate => $delegate_value:expr, argument => [$argument_value:expr, $argument_converter:ident]) => {
     let _: &mut AstConverter = $self;
     let end_position = $self.add_type_and_start(
-      &92u32.to_ne_bytes(),
+      &93u32.to_ne_bytes(),
       &$span,
       12,
       false,

diff --git a/scripts/ast-types.js b/scripts/ast-types.js
@@ -472,6 +472,11 @@ export const AST_NODES = {
 		estreeType: 'any',
 		useMacro: false
 	},
+	JSXSpreadChild: {
+		estreeType: 'any',
+		fields: [['expression', 'Node']],
+		useMacro: false
+	},
 	JSXText: {
 		estreeType: 'any',
 		fields: [

diff --git a/src/ast/bufferParsers.ts b/src/ast/bufferParsers.ts
@@ -60,6 +60,7 @@ import JSXMemberExpression from './nodes/JSXMemberExpression';
 import JSXNamespacedName from './nodes/JSXNamespacedName';
 import JSXOpeningElement from './nodes/JSXOpeningElement';
 import JSXOpeningFragment from './nodes/JSXOpeningFragment';
+import JSXSpreadChild from './nodes/JSXSpreadChild';
 import JSXText from './nodes/JSXText';
 import LabeledStatement from './nodes/LabeledStatement';
 import Literal from './nodes/Literal';
@@ -166,6 +167,7 @@ const nodeTypeStrings = [
 	'JSXNamespacedName',
 	'JSXOpeningElement',
 	'JSXOpeningFragment',
+	'JSXSpreadChild',
 	'JSXText',
 	'LabeledStatement',
 	'Literal',
@@ -262,6 +264,7 @@ const nodeConstructors: (typeof NodeBase)[] = [
 	JSXNamespacedName,
 	JSXOpeningElement,
 	JSXOpeningFragment,
+	JSXSpreadChild,
 	JSXText,
 	LabeledStatement,
 	Literal,
@@ -658,6 +661,10 @@ const bufferParsers: ((node: any, position: number, buffer: AstBuffer) => void)[
 		node.attributes = [];
 		node.selfClosing = false;
 	},
+	function jsxSpreadChild(node: JSXSpreadChild, position, buffer) {
+		const { scope } = node;
+		node.expression = convertNode(node, scope, buffer[position], buffer);
+	},
 	function jsxText(node: JSXText, position, buffer) {
 		node.value = buffer.convertString(buffer[position]);
 		node.raw = buffer.convertString(buffer[position + 1]);

diff --git a/src/ast/childNodeKeys.ts b/src/ast/childNodeKeys.ts
@@ -53,6 +53,7 @@ export const childNodeKeys: Record<string, string[]> = {
 	JSXNamespacedName: ['namespace', 'name'],
 	JSXOpeningElement: ['name', 'attributes'],
 	JSXOpeningFragment: [],
+	JSXSpreadChild: ['expression'],
 	JSXText: [],
 	LabeledStatement: ['label', 'body'],
 	Literal: [],

diff --git a/src/ast/nodes/JSXClosingElement.ts b/src/ast/nodes/JSXClosingElement.ts
@@ -1,8 +1,10 @@
 import type JSXIdentifier from './JSXIdentifier';
+import type JSXMemberExpression from './JSXMemberExpression';
+import type JSXNamespacedName from './JSXNamespacedName';
 import type * as NodeType from './NodeType';
 import JSXClosingBase from './shared/JSXClosingBase';
 
 export default class JSXClosingElement extends JSXClosingBase {
 	type!: NodeType.tJSXClosingElement;
-	name!: JSXIdentifier /* TODO | JSXMemberExpression | JSXNamespacedName */;
+	name!: JSXIdentifier | JSXMemberExpression | JSXNamespacedName;
 }