Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor API and Clarity Suggestions #3

Open
dbdimitrov opened this issue Mar 18, 2024 · 2 comments
Open

Minor API and Clarity Suggestions #3

dbdimitrov opened this issue Mar 18, 2024 · 2 comments

Comments

@dbdimitrov
Copy link

dbdimitrov commented Mar 18, 2024

Hi @rockdeme,

I will list a few suggestions which might improve the usability of the package.

  • Allow to pass top_p for features in the heatmap
  • cmap parameter to heatmap (currently it's defined internally, so it cannot be passed to seaborn).
  • top_n parameter for plot_weights
  • allow key to be passed to plot_weights, e.g. key=abs would enable top absolute weights to be plotted.
  • Clarify in the documentation how are shared SVGs determined when concating anndatas from multiple samples, is it the union, intersect, or some proportion?
  • Color legend for plot_samples is it possible to also add a legend based on the ~most extreme archetype?
  • having adata.uns['chr_aa']['alphas'] in obsm instead of uns would make it much easier to index.

Again great work, and these are just suggestions :)

Daniel

EDITED

@rockdeme
Copy link
Owner

Thanks again @dbdimitrov for going through the API and the suggestions, I'll make sure to review these for the upcoming version :)

@dbdimitrov
Copy link
Author

Also the 'sample' value is hardcoded here:

if sample_id not in adata.obs['sample'].cat.categories:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants