Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Owlv2 #643

Merged
merged 12 commits into from
Sep 17, 2024
Merged

Owlv2 #643

merged 12 commits into from
Sep 17, 2024

Conversation

probicheaux
Copy link
Collaborator

Description

Add owlv2 to inference

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

staging with ui

Any specific deployment considerations

inference-internal updated

Docs

  • Docs updated? What were the changes:

SolomonLake
SolomonLake previously approved these changes Sep 12, 2024
Copy link
Contributor

@SolomonLake SolomonLake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

SolomonLake
SolomonLake previously approved these changes Sep 12, 2024
@probicheaux
Copy link
Collaborator Author

@PawelPeczek-Roboflow this is ready for review

Copy link
Collaborator

@PawelPeczek-Roboflow PawelPeczek-Roboflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, besides minor comments and please add at least minimalistic docs describing what the model is useful for and how to make requests.

regarding CORE_MODEL_OWLV2_ENABLED=True in env - shall I assume the intent is to expose the model behind lambda?

inference/core/entities/requests/owlv2.py Show resolved Hide resolved
inference/models/owlv2/owlv2.py Outdated Show resolved Hide resolved
@PawelPeczek-Roboflow PawelPeczek-Roboflow merged commit 982a260 into main Sep 17, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants