Merge pull request grpc#6827 from jtattermusch/csharp_metadata_entry_…

…is_class Make Metadata.Entry a class
robcecil · Jun 8, 2016 · 7eaae43 · 7eaae43
2 parents 026dfe6 + c524ec0
commit 7eaae43
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/csharp/Grpc.Core/Metadata.cs b/src/csharp/Grpc.Core/Metadata.cs
@@ -95,6 +95,7 @@ public int IndexOf(Metadata.Entry item)
 
         public void Insert(int index, Metadata.Entry item)
         {
+            GrpcPreconditions.CheckNotNull(item);
             CheckWriteable();
             entries.Insert(index, item);
         }
@@ -114,13 +115,15 @@ public Metadata.Entry this[int index]
 
             set
             {
+                GrpcPreconditions.CheckNotNull(value);
                 CheckWriteable();
                 entries[index] = value;
             }
         }
 
         public void Add(Metadata.Entry item)
         {
+            GrpcPreconditions.CheckNotNull(item);
             CheckWriteable();
             entries.Add(item);
         }
@@ -187,7 +190,7 @@ private void CheckWriteable()
         /// <summary>
         /// Metadata entry
         /// </summary>
-        public struct Entry
+        public class Entry
         {
             private static readonly Encoding Encoding = Encoding.ASCII;
             private static readonly Regex ValidKeyRegex = new Regex("^[a-z0-9_-]+$");