Don't show the output panel in jake and grunt extensions

Fixes microsoft#64900
rjc · Dec 20, 2018 · 1386fba · 1386fba
1 parent 58e6b8f
commit 1386fba
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/extensions/grunt/src/main.ts b/extensions/grunt/src/main.ts
@@ -59,6 +59,12 @@ function getOutputChannel(): vscode.OutputChannel {
 	return _channel;
 }
 
+function showError() {
+	vscode.window.showWarningMessage(localize('gulpTaskDetectError', 'Problem finding jake tasks. See the output for more information.'),
+		localize('jakeShowOutput', 'Go to output')).then(() => {
+			getOutputChannel().show(true);
+		});
+}
 interface GruntTaskDefinition extends vscode.TaskDefinition {
 	task: string;
 	file?: string;
@@ -120,7 +126,7 @@ class FolderDetector {
 			let { stdout, stderr } = await exec(commandLine, { cwd: rootPath });
 			if (stderr) {
 				getOutputChannel().appendLine(stderr);
-				getOutputChannel().show(true);
+				showError();
 			}
 			let result: vscode.Task[] = [];
 			if (stdout) {
@@ -186,7 +192,7 @@ class FolderDetector {
 				channel.appendLine(err.stdout);
 			}
 			channel.appendLine(localize('execFailed', 'Auto detecting Grunt for folder {0} failed with error: {1}', this.workspaceFolder.name, err.error ? err.error.toString() : 'unknown'));
-			channel.show(true);
+			showError();
 			return emptyTasks;
 		}
 	}

diff --git a/extensions/jake/src/main.ts b/extensions/jake/src/main.ts
@@ -59,6 +59,13 @@ function getOutputChannel(): vscode.OutputChannel {
 	return _channel;
 }
 
+function showError() {
+	vscode.window.showWarningMessage(localize('gulpTaskDetectError', 'Problem finding jake tasks. See the output for more information.'),
+		localize('jakeShowOutput', 'Go to output')).then(() => {
+			getOutputChannel().show(true);
+		});
+}
+
 interface JakeTaskDefinition extends vscode.TaskDefinition {
 	task: string;
 	file?: string;
@@ -124,7 +131,7 @@ class FolderDetector {
 			let { stdout, stderr } = await exec(commandLine, { cwd: rootPath });
 			if (stderr) {
 				getOutputChannel().appendLine(stderr);
-				getOutputChannel().show(true);
+				showError();
 			}
 			let result: vscode.Task[] = [];
 			if (stdout) {
@@ -163,7 +170,7 @@ class FolderDetector {
 				channel.appendLine(err.stdout);
 			}
 			channel.appendLine(localize('execFailed', 'Auto detecting Jake for folder {0} failed with error: {1}', this.workspaceFolder.name, err.error ? err.error.toString() : 'unknown'));
-			channel.show(true);
+			showError();
 			return emptyTasks;
 		}
 	}