Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(udf): allow udaf as window function #18181

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Aug 22, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Fix #17560.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@stdrc stdrc marked this pull request as ready for review August 22, 2024 07:19
@stdrc stdrc changed the title infer return type for udaf fix(udf): allow udaf as window function Aug 22, 2024
@github-actions github-actions bot added type/fix Bug fix and removed Invalid PR Title labels Aug 22, 2024
@stdrc stdrc requested review from BugenZhao, xxchan and chenzl25 August 22, 2024 07:20
@stdrc stdrc force-pushed the rc/fix-function-binder branch from 0ec8cd5 to 830794c Compare August 22, 2024 10:13
@stdrc stdrc force-pushed the rc/fix-udaf-as-window-function branch from 6c93f94 to 95f2477 Compare August 22, 2024 10:13
@stdrc stdrc force-pushed the rc/fix-function-binder branch from 830794c to 8574edc Compare August 22, 2024 14:04
@stdrc stdrc force-pushed the rc/fix-udaf-as-window-function branch from 95f2477 to 0ee1e49 Compare August 22, 2024 14:04
Base automatically changed from rc/fix-function-binder to main August 22, 2024 17:01
@graphite-app graphite-app bot requested a review from a team August 22, 2024 17:03
stdrc added 2 commits August 23, 2024 01:03
Signed-off-by: Richard Chien <stdrc@outlook.com>
Signed-off-by: Richard Chien <stdrc@outlook.com>
@stdrc stdrc force-pushed the rc/fix-udaf-as-window-function branch from 0ee1e49 to 41a1a96 Compare August 22, 2024 17:04
@stdrc stdrc enabled auto-merge August 22, 2024 17:04
@stdrc stdrc added this pull request to the merge queue Aug 22, 2024
Merged via the queue into main with commit c83ce86 Aug 22, 2024
30 of 31 checks passed
@stdrc stdrc deleted the rc/fix-udaf-as-window-function branch August 22, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: UDAF can not be used as window function
2 participants