fix: add back parser support of label #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Omega359 May you try whether it works for you? |
I will try this out hopefully today or tomorrow - thanks for the ping! |
|
I tested this with DataFusion pointing to the branch source for this PR and it seems to work as expected. Thanks! |
Signed-off-by: Eric Fu <fuyufjh@gmail.com>
fuyufjh
force-pushed
the
eric/support_label_in_parser
branch
from
64bd3ed to
f7c2eee
Compare
Signed-off-by: xxchan <xxchan22f@gmail.com>
xxchan
approved these changes
Jan 6, 2025
|
0.26.0 published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring back the parser support for
<label>ofquerytests.Note that the label doesn't function as expected. This PR only supports it in parser so that a valid
.sltfile won't panicSee more background in #242.