Add RetrieveList specs and update webmock

richo225 · Feb 11, 2018 · 5e8b243 · 5e8b243
1 parent ef26780
commit 5e8b243
Show file tree

Hide file tree

Showing 12 changed files with 619 additions and 12 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -18,7 +18,7 @@ GEM
       safe_yaml (~> 1.0.0)
     diff-lcs (1.3)
     formatador (0.2.5)
-    hashdiff (0.3.0)
+    hashdiff (0.3.7)
     httparty (0.15.7)
       multi_xml (>= 0.5.2)
     method_source (0.8.2)
@@ -62,7 +62,7 @@ GEM
     thor (0.20.0)
     unicode-display_width (1.3.0)
     vcr (3.0.3)
-    webmock (2.1.0)
+    webmock (3.2.1)
       addressable (>= 2.3.6)
       crack (>= 0.3.2)
       hashdiff
@@ -78,7 +78,7 @@ DEPENDENCIES
   rspec (~> 3.0)
   rubocop (~> 0.52.1)
   vcr
-  webmock
+  webmock (~> 3.2.1)
 
 BUNDLED WITH
    1.16.1
diff --git a/hodlmoon.gemspec b/hodlmoon.gemspec
@@ -42,5 +42,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rubocop', '~> 0.52.1'
   spec.add_development_dependency 'vcr'
-  spec.add_development_dependency 'webmock'
+  spec.add_development_dependency 'webmock', '~> 3.2.1'
 end
diff --git a/lib/hodlmoon/client/retrieve_list.rb b/lib/hodlmoon/client/retrieve_list.rb
@@ -14,7 +14,7 @@ def call
       private
 
       def uri
-        "https://api.coinmarketcap.com/v1/ticker?limit=#{@limit}&convert=#{@currency}"
+        "https://api.coinmarketcap.com/v1/ticker/?limit=#{@limit}&convert=#{@currency}"
       end
     end
   end

diff --git a/spec/client/retrieve_list_spec.rb b/spec/client/retrieve_list_spec.rb
@@ -0,0 +1,31 @@
+require 'pry'
+
+RSpec.describe Hodlmoon::Client::RetrieveList do
+  describe '#call', :vcr do
+    subject(:client) { described_class.call(12, currency) }
+
+    context 'with gbp' do
+      let(:currency) { 'gbp' }
+
+      it 'returns the correct limit' do
+        expect(client.count).to eq(12)
+      end
+
+      it 'returns the gbp headers' do
+        expect(client.first.keys).to include('price_gbp', '24h_volume_gbp', 'market_cap_gbp')
+      end
+    end
+
+    context 'with usd' do
+      let(:currency) { 'usd' }
+
+      it 'returns the correct limit' do
+        expect(client.count).to eq(12)
+      end
+
+      it 'returns the usd headers' do
+        expect(client.first.keys).to include('price_usd', '24h_volume_usd', 'market_cap_usd')
+      end
+    end
+  end
+end
diff --git a/spec/client/coin_market_cap_spec.rb → spec/client/retrieve_price_spec.rb b/spec/client/coin_market_cap_spec.rb → spec/client/retrieve_price_spec.rb
@@ -1,6 +1,6 @@
-RSpec.describe Hodlmoon::Client::CoinMarketCap do
-  describe '#retrieve_price', :vcr do
-    subject(:client) { described_class.retrieve_price('ethereum', currency) }
+RSpec.describe Hodlmoon::Client::RetrievePrice do
+  describe '#call', :vcr do
+    subject(:client) { described_class.call('ethereum', currency) }
 
     context 'with gbp' do
       let(:currency) { 'gbp' }

diff --git a/spec/hodlmoon_spec.rb b/spec/hodlmoon_spec.rb
@@ -2,8 +2,4 @@
   it 'has a version number' do
     expect(Hodlmoon::VERSION).not_to be nil
   end
-
-  it 'does something useful' do
-    expect(false).to eq(true)
-  end
 end
diff --git a/spec/vcr/Hodlmoon_Client_RetrieveList/_call/with_gbp/returns_the_correct_limit.yml b/spec/vcr/Hodlmoon_Client_RetrieveList/_call/with_gbp/returns_the_correct_limit.yml
-Original file line number
+Diff line change
@@ Expand Up / @@ -14,7 +14,7 @@ def call @@
           private
           def uri
-            "https://api.coinmarketcap.com/v1/ticker?limit=#{@limit}&convert=#{@currency}"
+            "https://api.coinmarketcap.com/v1/ticker/?limit=#{@limit}&convert=#{@currency}"
           end
         end
       end
@@ Expand Down @@