Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macos-15 runner label support #453

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

muzimuzhi
Copy link
Contributor

This PR is based on the head of #451.

I didn't add macos-15-xl as it's unknown whether it's supported or not.

@rhysd
Copy link
Owner

rhysd commented Sep 27, 2024

It seems that macos-15 runner is not GA yet. Do you know any official documentation mentioning macos-15 runner?

github/roadmap#986

@rhysd
Copy link
Owner

rhysd commented Sep 27, 2024

I found the official resource: https://github.com/actions/runner-images?tab=readme-ov-file#available-images

This PR sounds good to be merged.

I didn't add macos-15-xl as it's unknown whether it's supported or not.

It is not documented in the above document. So let's not include it for now.

@muzimuzhi
Copy link
Contributor Author

muzimuzhi commented Sep 27, 2024

It seems that macos-15 runner is not GA yet.

Yes. It's just in public beta.
https://github.blog/changelog/2024-09-25-actions-new-images-and-ubuntu-latest-changes/

(This info was also mentioned in commit message.)

I didn't add macos-15-xl as it's unknown whether it's supported or not.

It is not documented in the above document. So let's not include it for now.

Actually none of the macos-<n>-xl labels are listed in https://github.com/actions/runner-images?tab=readme-ov-file#available-images.

"Good news" is that it's announced that macos-12-xl, macos-13-xl, and macos-13-xl-arm64 will be deprecated on Dec 3, 2024.
https://github.blog/changelog/2024-08-19-notice-of-upcoming-deprecations-and-breaking-changes-in-github-actions-runners/

@muzimuzhi muzimuzhi marked this pull request as ready for review September 27, 2024 14:53
Copy link
Owner

@rhysd rhysd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good.

@rhysd rhysd merged commit aa1a6d2 into rhysd:main Sep 27, 2024
14 checks passed
@muzimuzhi muzimuzhi deleted the add-macos-15 branch September 27, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants