Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to latest modulekit #5

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Conversation

highskore
Copy link
Contributor

No description provided.

@highskore highskore requested a review from kopy-kat December 9, 2024 09:27
@highskore highskore marked this pull request as draft December 9, 2024 09:29
@highskore highskore marked this pull request as ready for review December 9, 2024 09:59
package.json Outdated
@@ -25,7 +25,10 @@
"test:optimized": "pnpm run build:optimized && FOUNDRY_PROFILE=test-optimized forge test"
},
"dependencies": {
"@rhinestone/modulekit": "^0.4.17"
"@rhinestone/modulekit": "github:rhinestonewtf/modulekit#ab4ab5d382a1bab3dea1c88ecf0d050e111e2db4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not npm and modulekit latest?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was testing out the via-ir fix, are we going to bump it again?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yeah lets release a new version after via-ir

@highskore highskore merged commit 3cc2715 into main Dec 9, 2024
5 checks passed
@highskore highskore deleted the feat/update-modulekit-dep branch December 9, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants