Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Webauthn module to support hex/byte inputs + viem compatible types #107

Merged
merged 8 commits into from
Dec 12, 2024
Merged

Update Webauthn module to support hex/byte inputs + viem compatible types #107

merged 8 commits into from
Dec 12, 2024

Conversation

KaiCode2
Copy link
Contributor

Implements

  • Allows hex or bytes inputs to be passed as inputs to Webauthn module. Users no longer required to parse keys themselves
  • Update installation input params to match wevm's P256Credential (ox lib form too)
  • Update usage input params to match wevm's WebauthnData and P256 signature format

Limitations

  • Public key decoding only supports uncompressed key format - with or without 0x04 prefix

kopy-kat
kopy-kat approved these changes Dec 12, 2024
View reviewed changes
src/module/webauthn-validator/usage.ts Outdated Show resolved Hide resolved
src/module/webauthn-validator/types.ts Show resolved Hide resolved
src/module/webauthn-validator/utils.ts Show resolved Hide resolved
@kopy-kat kopy-kat merged commit 8648b44 into rhinestonewtf:main Dec 12, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kopy-kat kopy-kat kopy-kat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KaiCode2 @kopy-kat