Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prepare release #724

Merged
merged 5 commits into from
Feb 24, 2023
Merged

feat: prepare release #724

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5e922c6
feat: do review only if not the same
ferreiratiago Feb 23, 2023
81172aa
feat: add reviewpad run command
ferreiratiago Feb 23, 2023
6ba7d7f
test: add coverage for is reviewpad command run
zolamk Feb 24, 2023
8273cf7
fix: skipping review check
zolamk Feb 24, 2023
3869f29
test: add coverage for skipping review
zolamk Feb 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: skipping review check
  • Loading branch information
@zolamk
zolamk committed Feb 24, 2023
commit 8273cf76aba89ee4c77b1fb8cfdcdf436704738f
2 changes: 1 addition & 1 deletion plugins/aladino/actions/review.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ func reviewCode(e aladino.Env, args []aladino.Value) error {

// If the latest review is the same as the one we want to create, and the last push date is before the latest review
// then we skip the review creation.
if latestReview.State == reviewEvent && latestReview.Body == reviewBody && lastPushDate.Before(*latestReview.SubmittedAt) {
if latestReviewEvent == reviewEvent && latestReview.Body == reviewBody && lastPushDate.Before(*latestReview.SubmittedAt) {
log.Infof("skipping review because there were no updates since the last review")
return nil
}
Expand Down