Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit tests for engine exec #180

Merged
merged 11 commits into from
Aug 8, 2022
Merged

test: add unit tests for engine exec #180

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2919267
test: add unit tests for engine exec
shay2025 Jul 27, 2022
afbaf37
chore: fix indentation
shay2025 Jul 28, 2022
f6bed8c
refactor: variable renaming in engine exec
shay2025 Aug 1, 2022
1ef2d77
refactor: improve engine mocks
shay2025 Aug 1, 2022
93724ca
refactor: improve engine exec unit tests
shay2025 Aug 1, 2022
8f69c4d
refactor: apply TDTs to engine exec
shay2025 Aug 8, 2022
09d5e1f
fix: remove BuildMetadata from engine exec tests
shay2025 Aug 8, 2022
74656c6
refactor: rename engine exec unit test func
shay2025 Aug 8, 2022
3e9b3cb
refactor: improve engine exec unit tests
shay2025 Aug 8, 2022
50a9ca2
test: add testutils to engine
shay2025 Aug 8, 2022
421af0c
refactor: add condition to reset imports in ParseReviewpadFile
shay2025 Aug 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: variable renaming in engine exec
  • Loading branch information
@shay2025
shay2025 committed Aug 8, 2022
commit f6bed8cfe2e553ec84a66fc0ef6e57a051db66ee
8 changes: 4 additions & 4 deletions engine/exec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,18 +25,18 @@ func execLog(val string) {
}

func CollectError(env *Env, err error) {
var errDetails string
var errMsg string
ghError, isGitHubError := err.(*github.ErrorResponse)

if isGitHubError {
errDetails = ghError.Message
errMsg = ghError.Message
} else {
errDetails = err.Error()
errMsg = err.Error()
}

env.Collector.Collect("Error", map[string]interface{}{
"pullRequestUrl": env.PullRequest.URL,
"details": errDetails,
"details": errMsg,
})
}

Expand Down