Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-pr-review: Support multiline comments #680

Merged
merged 9 commits into from
Jul 22, 2020
Merged

github-pr-review: Support multiline comments #680

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3d89ad0
github-pr-review: Support multiline comments
haya14busa Jul 22, 2020
db3d925
github-pr-review: Add multiline tests
haya14busa Jul 22, 2020
cc52dd4
github-pr-review: fix multiline comments
haya14busa Jul 22, 2020
8861f77
add more tests
haya14busa Jul 22, 2020
198d9f3
Do not use go as custom text data target
haya14busa Jul 22, 2020
12ee008
fix existing comments handling
haya14busa Jul 22, 2020
fdb9091
fix existing comments handlings for line-break range comments
haya14busa Jul 22, 2020
3d19f58
github-pr-review: fix multiline comments which is partially outside d…
haya14busa Jul 22, 2020
add7f7b
Update CHANGELOG
haya14busa Jul 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update CHANGELOG
  • Loading branch information
@haya14busa
haya14busa committed Jul 22, 2020
commit add7f7b004c40accf54a1397a808087f0e89b6b6
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### :rocket: Enhancements
- [#629](https://github.com/reviewdog/reviewdog/pull/629) Introduced Reviewdog Diagnostic Format. ([@haya14busa])
- [#674](https://github.com/reviewdog/reviewdog/pull/674) Support rdjsonl as input format
- [#680](https://github.com/reviewdog/reviewdog/pull/680) github-pr-review: Support multiline comments
- ...

### :bug: Fixes
Expand Down