Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added automatic 'index.js' append to require() arugments that end in … #1822

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added automatic 'index.js' append to require() arugments that end in … #1822

wants to merge 4 commits into from

Conversation

Tythos
Copy link

@Tythos Tythos commented Dec 11, 2020

…'/'; test and documentation added for this feature as a packaging shortcut; addresses feature proposed in Issue #1711

Note: CLA link now forwards from JQuery Foundation CLA (https://contribute.jquery.org/CLA/) to OpenJSF membership (https://openjsf.org/). Not sure what you want the new CLA-like agreement process to be? This may require a separate issue (meta-issue?) for project.

Added automatic 'index.js' append to require() arugments that end in …
13a81dc 
…'/'; test and documentation added for this feature as a packaging shortcut; addresses feature proposed in requirejs#1711
@Tythos
Copy link
Author

Tythos commented Dec 11, 2020

Update on CLA comment: Signed from link in CI checks. May want to change link in page docs?

@Tythos
Copy link
Author

Tythos commented Dec 12, 2020

CI failure appears to come from "const" usage within strict mode for chalk; not clear to me why this would be related to any commit changes. Other PRs appear to be bypassing, perhaps because they are on non-master branches from source fork for CI trigger? Unclear at this time.

@Tythos
Copy link
Author

Tythos commented Dec 12, 2020

The CI build fails with identical results on <requirejs/requirejs> :master #898ff9e6.

> docker run -it node:0.12 bash
# git clone --depth=50 https://github.com/requirejs/requirejs.git requirejs/requirejs
# cd requirejs/requirejs
# npm install
# npm test

> requirejs@ pretest /requirejs/requirejs
> jscs . && jshint require.js

/requirejs/requirejs/node_modules/jscs/node_modules/cli-table/node_modules/chalk/index.js:2
const escapeStringRegexp = require('escape-string-regexp');
^^^^^
SyntaxError: Use of const in strict mode.
    at exports.runInThisContext (vm.js:73:16)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Tythos