[#2209] Skip blank lines in blurb file url #2239
Conversation
There was a problem hiding this comment.
Thanks for working on this @jedkohjk! Could you update the unit and system tests to include test cases for this scenario?
| for (url = ""; url.length() == 0; url = lines.get(position++).strip()) { | ||
| // checks if delimiter is the last non-blank line | ||
| if (position >= lines.size()) { | ||
| return null; | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit: This works well enough, but we can consider using a while loop, as the linear flow would make it easier to read.
There was a problem hiding this comment.
Updated to use a while loop
Modified blurbs files in test resources to account for this scenario |
|
@jedkohjk Can you update all your PR titles to include the issue number as per the expected format? |
jedkohjk
changed the title
Updated. Sorry, didn't notice the format previously. |
|
The following links are for previewing this pull request:
|
Resolves #2209
Proposed commit message