Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CSS side effect imports #4919

Merged
merged 115 commits into from
Jan 4, 2023
Merged

feat: CSS side effect imports #4919

Changes from 1 commit
Commits
Show all changes
115 commits
Select commit Hold shift + click to select a range
8b9d1b8
add initial CSS Modules integration
markdalgleish Nov 24, 2022
4cc9f8e
only write CSS bundle and source map to disk
markdalgleish Nov 24, 2022
5a55f96
Only emit CSS from the CSS bundle build
markdalgleish Nov 24, 2022
72de4a3
Merge branch 'dev' into markdalgleish/css-modules
markdalgleish Nov 24, 2022
fc57bae
bump css-bundle version
markdalgleish Nov 24, 2022
5d96e1c
clean up CSS build output logic
markdalgleish Nov 28, 2022
48aaaf3
dispose CSS compiler in browser compiler
markdalgleish Nov 28, 2022
9f40c89
remove emitCss option, clean up server output
markdalgleish Nov 28, 2022
83eb997
make CSS Modules object type readonly
markdalgleish Nov 28, 2022
0dcd2dc
add initial CSS Modules integration test
markdalgleish Nov 29, 2022
33b09aa
refactor local fork of CSS Modules plugin
markdalgleish Nov 29, 2022
1352cc5
bundle CSS to support composes property
markdalgleish Dec 5, 2022
ec7e32a
put CSS Modules behind v2_cssBundle future flag
markdalgleish Dec 6, 2022
6381250
Merge branch 'dev' into markdalgleish/css-modules
markdalgleish Dec 6, 2022
b4e2168
update css-bundle versions
markdalgleish Dec 6, 2022
1599d3a
rename v2_cssBundle flag to unstable_cssBundle
markdalgleish Dec 6, 2022
88a0761
remove CSS Module entry point cache
markdalgleish Dec 6, 2022
f31cd7a
inline setup and buildCssModulesJs functions
markdalgleish Dec 6, 2022
600897a
remove build context, clean up path resolution
markdalgleish Dec 6, 2022
657ef3e
use esbuild's resolver in lightningcss
markdalgleish Dec 7, 2022
55653e7
refactor CSS Modules plugin
markdalgleish Dec 7, 2022
08a6f66
upgrade lightningcss
markdalgleish Dec 7, 2022
d6d4d70
use relative path for filename
markdalgleish Dec 7, 2022
ccf946f
add workaround for CSS Modules hash clashes
markdalgleish Dec 7, 2022
e63338d
simplify esbuild plugin, add PluginData type
markdalgleish Dec 8, 2022
ea3e3bd
namespace compiled CSS suffix
markdalgleish Dec 8, 2022
be03658
use complete path for virtual CSS file name
markdalgleish Dec 8, 2022
e2c2d1a
split CSS Modules test cases, add more, clean up
markdalgleish Dec 8, 2022
abdd5d3
Merge branch 'dev' into markdalgleish/css-modules
markdalgleish Dec 8, 2022
1dc7da5
bump css-bundle versions
markdalgleish Dec 8, 2022
5254c2e
add unstable_cssBundle default to test package
markdalgleish Dec 8, 2022
3117fe4
ensure scoped grid line names don't break build
markdalgleish Dec 8, 2022
3e95c07
add CSS Modules to deterministic build test
markdalgleish Dec 8, 2022
78f74bd
ensure stable hashes when using import composition
markdalgleish Dec 8, 2022
57f688c
add comment explaining pattern order
markdalgleish Dec 8, 2022
1e0c3a1
add comment about cwd limitation
markdalgleish Dec 8, 2022
41f65cf
Merge branch 'dev' into markdalgleish/css-modules
markdalgleish Dec 8, 2022
d17e6cd
add test for root relative image URLs
markdalgleish Dec 9, 2022
0641e8c
Merge branch 'dev' into markdalgleish/css-modules
markdalgleish Dec 11, 2022
c8b8c33
fix esbuild resolve error after upgrade
markdalgleish Dec 11, 2022
21c9e0b
add CSS bundle deduplication test
markdalgleish Dec 11, 2022
568adf2
clean up tests
markdalgleish Dec 12, 2022
de3e1c3
rename test
markdalgleish Dec 12, 2022
039233b
support import side effects in client entry
markdalgleish Dec 12, 2022
6ae02b2
add trailing newline to tsconfig
markdalgleish Dec 12, 2022
4a38a94
update FutureConfig type, sort keys
markdalgleish Dec 12, 2022
2c5eb5a
add changeset
markdalgleish Dec 12, 2022
be5b9cc
add initial docs
markdalgleish Dec 12, 2022
61ac3c5
migrate to postcss-modules, add tests and clean up
markdalgleish Dec 13, 2022
9709d24
hoist postcss imports
markdalgleish Dec 13, 2022
385aed5
format tsconfig
markdalgleish Dec 13, 2022
a774503
reorder imports
markdalgleish Dec 13, 2022
66b0ad8
reorder options
markdalgleish Dec 13, 2022
77080dd
add root relative class composition to test
markdalgleish Dec 13, 2022
beec55a
clean up css-bundle dist, add typings field
markdalgleish Dec 13, 2022
778e4d2
Merge branch 'dev' into markdalgleish/css-modules
markdalgleish Dec 13, 2022
a698f16
update note about CSS Modules support
markdalgleish Dec 13, 2022
ac9e013
fix docs formatting
markdalgleish Dec 13, 2022
1bf956f
update readme and description
markdalgleish Dec 13, 2022
e06857c
update comment
markdalgleish Dec 13, 2022
718909f
don't provide default object for entrypoints
markdalgleish Dec 13, 2022
696e2c0
remove redundant type annotations
markdalgleish Dec 13, 2022
d05e29f
remove redundant relative path
markdalgleish Dec 13, 2022
df3aa42
simplify css compiler build step
markdalgleish Dec 13, 2022
fffb86d
add comment explaining exports in css entry
markdalgleish Dec 13, 2022
5baeff3
add comment explaining resolved module contents
markdalgleish Dec 13, 2022
0243f83
simplify plugin data
markdalgleish Dec 13, 2022
3438678
use arrow functions for fixtures to reduce nesting
markdalgleish Dec 13, 2022
8fc72b6
nit formatting
markdalgleish Dec 13, 2022
a5a1e27
switch from patch to minor release
markdalgleish Dec 13, 2022
806f033
convert unstable_cssBundle value to nested object
markdalgleish Dec 13, 2022
61088c2
reinstate relative path to improve CSS comments
markdalgleish Dec 13, 2022
a3e95d1
Merge branch 'dev' into markdalgleish/css-modules
markdalgleish Dec 13, 2022
6347b79
flatten CSS Modules feature flag
markdalgleish Dec 13, 2022
84131d3
make virtual css paths relative to root dir
markdalgleish Dec 13, 2022
8257efc
rename CSS entry module ID and plugin
markdalgleish Dec 14, 2022
b8f6d42
convert cssBundleHref to named export
markdalgleish Dec 14, 2022
0797be5
WIP
markdalgleish Dec 18, 2022
7ed88e0
Merge branch 'dev' into markdalgleish/css-modules
markdalgleish Dec 18, 2022
2a5098e
bump css-bundle versions
markdalgleish Dec 18, 2022
b6893f3
Merge branch 'markdalgleish/css-modules' into markdalgleish/css-side-…
markdalgleish Dec 18, 2022
1dbfaff
update lock file
markdalgleish Dec 18, 2022
50772f9
use Babel to transform imports, handle more cases
markdalgleish Dec 19, 2022
fa2d219
Merge branch 'dev' into markdalgleish/css-modules
markdalgleish Dec 19, 2022
d774052
Merge branch 'markdalgleish/css-modules' into markdalgleish/css-side-…
markdalgleish Dec 20, 2022
19dc2b7
Merge branch 'dev' into markdalgleish/css-modules
markdalgleish Dec 20, 2022
fbc9941
Merge branch 'markdalgleish/css-modules' into markdalgleish/css-side-…
markdalgleish Dec 20, 2022
d4d34d1
add test cases for named and namespace imports
markdalgleish Dec 20, 2022
141ff02
Merge branch 'dev' into markdalgleish/css-modules
markdalgleish Dec 20, 2022
2a0e54b
Merge branch 'markdalgleish/css-modules' into markdalgleish/css-side-…
markdalgleish Dec 20, 2022
aece1ee
don't output CSS Modules in server/app build
markdalgleish Dec 20, 2022
afa7d11
Merge branch 'markdalgleish/css-modules' into markdalgleish/css-side-…
markdalgleish Dec 20, 2022
d9d1ebe
fix isCssBuild
markdalgleish Dec 20, 2022
5b2710c
handle images in CSS side effects
markdalgleish Dec 21, 2022
c2a2c3c
nest fixture files in separate directories
markdalgleish Dec 21, 2022
436d28a
clean up test CSS
markdalgleish Dec 21, 2022
fd6d3ed
Update docs/guides/migrating-react-router-app.md
markdalgleish Dec 21, 2022
6a30fb5
Update docs/guides/styling.md
markdalgleish Dec 21, 2022
cc96521
Update docs/guides/styling.md
markdalgleish Dec 21, 2022
5cb0efb
Update docs/guides/styling.md
markdalgleish Dec 21, 2022
cc5dc69
Update packages/remix-dev/compiler/compileBrowser.ts
markdalgleish Dec 21, 2022
3ebae45
Update packages/remix-dev/compiler/compileBrowser.ts
markdalgleish Dec 21, 2022
f0c7b82
Update docs/guides/styling.md
markdalgleish Dec 21, 2022
0da587d
dedupe CSS in dev
markdalgleish Dec 21, 2022
c7357fa
remove explicit single CSS file warning from docs
markdalgleish Dec 21, 2022
146ae5d
remove redundant optional chaining
markdalgleish Dec 21, 2022
ea9f2dc
Merge branch 'dev' into markdalgleish/css-modules
markdalgleish Dec 22, 2022
e230a36
Merge branch 'markdalgleish/css-modules' into markdalgleish/css-side-…
markdalgleish Dec 22, 2022
983cd2b
remove explicit single CSS file warning
markdalgleish Dec 22, 2022
26836e8
update docs
markdalgleish Dec 22, 2022
9386ce9
use consistent casing
markdalgleish Dec 22, 2022
4e0023d
rename "side effects" to "side-effect imports"
markdalgleish Dec 22, 2022
c8aa066
clean up regular expression
markdalgleish Dec 22, 2022
e8e5829
Merge branch 'dev' into markdalgleish/css-side-effects
markdalgleish Jan 4, 2023
a3abcbf
update docs
markdalgleish Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
split CSS Modules test cases, add more, clean up
  • Loading branch information
@markdalgleish
markdalgleish committed Dec 8, 2022
commit e2c2d1adf3ad1a01af77db09fe7c42969ff258d2
Loading