Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-dev/cli): Remove excess fetching and improve error handling #2500

Merged
merged 18 commits into from
Mar 30, 2022
Merged

fix(remix-dev/cli): Remove excess fetching and improve error handling #2500

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ec9cbec
fix(cli): Remove excess fetching + error handling
chaance Mar 25, 2022
2da79b4
Merge branch 'dev' of github.com:remix-run/remix into chance/cli-opti…
chaance Mar 25, 2022
ab86188
rm error
chaance Mar 25, 2022
f6eb0e3
update tests
chaance Mar 26, 2022
bbca18b
Check for existing template before extraction
chaance Mar 26, 2022
a30bbd9
fix stack entries
chaance Mar 27, 2022
4813297
move validation to initial run stage
chaance Mar 28, 2022
c0d5e12
Merge branch 'dev' of github.com:remix-run/remix into chance/cli-opti…
chaance Mar 28, 2022
34ccdee
simplify error handling
chaance Mar 28, 2022
1111563
re-org and fix bug
chaance Mar 28, 2022
64d5cf0
tweak error handling
chaance Mar 28, 2022
937e804
Merge branch 'dev' into chance/cli-optimizations
chaance Mar 28, 2022
a4821a2
Merge branch 'dev' into chance/cli-optimizations
chaance Mar 28, 2022
178569b
rm extra case
chaance Mar 28, 2022
25faed6
fix logging and update tests
chaance Mar 28, 2022
15f77bd
formatting
chaance Mar 29, 2022
e83cb14
formatting
chaance Mar 29, 2022
cd5451d
Update packages/remix-dev/cli/run.ts
chaance Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update packages/remix-dev/cli/run.ts 
Co-authored-by: Logan McAnsh <logan@mcan.sh>
  • Loading branch information
@chaance @mcansh
chaance and mcansh authored Mar 29, 2022
commit cd5451dbf693aeecdc19c30fcc659a790fb742cc
3 changes: 2 additions & 1 deletion packages/remix-dev/cli/run.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,8 @@ export async function run(argv: string[] = process.argv.slice(2)) {
templateType! || (answers.appType === "stack" ? "repo" : "template"),
projectDir,
remixVersion: flags.remixVersion,
installDeps: flags.install ?? answers.install,
installDeps: flags.install || answers.install,
useTypeScript: flags.typescript || answers.useTypeScript,
useTypeScript: flags.typescript ?? answers.useTypeScript,
Copy link
Collaborator

@mcansh mcansh Mar 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh oops, the commit suggestion didn't let me remove the previous useTypeScript 🤦

and appTemplate needs to be updated to || as well :oof:

githubToken: process.env.GITHUB_TOKEN,
});
Expand Down