chore(templates): fix ESLint errors (#4029)

remix-run · Aug 20, 2022 · f4d6ff6 · f4d6ff6
1 parent ba5c848
commit f4d6ff6
Show file tree

Hide file tree

Showing 9 changed files with 25 additions and 16 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -1,3 +1,7 @@
+const OFF = 0;
+const WARN = 1;
+
+/** @type {import('eslint').Linter.Config} */
 module.exports = {
   root: true,
   extends: [
@@ -9,7 +13,15 @@ module.exports = {
     {
       files: ["rollup.config.js"],
       rules: {
-        "import/no-extraneous-dependencies": 0,
+        "import/no-extraneous-dependencies": OFF,
+      },
+    },
+    {
+      files: ["templates/**/*.*"],
+      rules: {
+        "prefer-const": WARN,
+
+        "prefer-let/prefer-let": OFF,
       },
     },
   ],

diff --git a/templates/.eslintrc.js b/templates/.eslintrc.js
diff --git a/templates/cloudflare-pages/app/entry.server.tsx b/templates/cloudflare-pages/app/entry.server.tsx
@@ -8,7 +8,7 @@ export default function handleRequest(
   responseHeaders: Headers,
   remixContext: EntryContext
 ) {
-  let markup = renderToString(
+  const markup = renderToString(
     <RemixServer context={remixContext} url={request.url} />
   );
 

diff --git a/templates/cloudflare-workers/app/entry.server.tsx b/templates/cloudflare-workers/app/entry.server.tsx
@@ -8,7 +8,7 @@ export default function handleRequest(
   responseHeaders: Headers,
   remixContext: EntryContext
 ) {
-  let markup = renderToString(
+  const markup = renderToString(
     <RemixServer context={remixContext} url={request.url} />
   );
 

diff --git a/templates/express/app/entry.server.tsx b/templates/express/app/entry.server.tsx
@@ -15,11 +15,11 @@ export default function handleRequest(
   return new Promise((resolve, reject) => {
     let didError = false;
 
-    let { pipe, abort } = renderToPipeableStream(
+    const { pipe, abort } = renderToPipeableStream(
       <RemixServer context={remixContext} url={request.url} />,
       {
         onShellReady: () => {
-          let body = new PassThrough();
+          const body = new PassThrough();
 
           responseHeaders.set("Content-Type", "text/html");
 

diff --git a/templates/express/server.js b/templates/express/server.js
@@ -53,7 +53,7 @@ function purgeRequireCache() {
   // alternatively you can set up nodemon/pm2-dev to restart the server on
   // file changes, but then you'll have to reconnect to databases/etc on each
   // change. We prefer the DX of this, so we've included it for you by default
-  for (let key in require.cache) {
+  for (const key in require.cache) {
     if (key.startsWith(BUILD_DIR)) {
       delete require.cache[key];
     }

diff --git a/templates/fly/app/entry.server.tsx b/templates/fly/app/entry.server.tsx
@@ -15,11 +15,11 @@ export default function handleRequest(
   return new Promise((resolve, reject) => {
     let didError = false;
 
-    let { pipe, abort } = renderToPipeableStream(
+    const { pipe, abort } = renderToPipeableStream(
       <RemixServer context={remixContext} url={request.url} />,
       {
         onShellReady: () => {
-          let body = new PassThrough();
+          const body = new PassThrough();
 
           responseHeaders.set("Content-Type", "text/html");
 

diff --git a/templates/netlify/server.js b/templates/netlify/server.js
@@ -17,14 +17,14 @@ function getLoadContext(event, context) {
     netlifyGraphToken = event.authlifyToken;
   }
 
-  let authHeader = event.headers["authorization"];
-  let graphSignatureHeader = event.headers["x-netlify-graph-signature"];
+  const authHeader = event.headers["authorization"];
+  const graphSignatureHeader = event.headers["x-netlify-graph-signature"];
 
   if (authHeader != null && /Bearer /gi.test(authHeader)) {
     rawAuthorizationString = authHeader.split(" ")[1];
   }
 
-  let loadContext = {
+  const loadContext = {
     clientNetlifyGraphAccessToken: rawAuthorizationString,
     netlifyGraphToken: netlifyGraphToken,
     netlifyGraphSignature: graphSignatureHeader,

diff --git a/templates/remix/app/entry.server.tsx b/templates/remix/app/entry.server.tsx
@@ -15,11 +15,11 @@ export default function handleRequest(
   return new Promise((resolve, reject) => {
     let didError = false;
 
-    let { pipe, abort } = renderToPipeableStream(
+    const { pipe, abort } = renderToPipeableStream(
       <RemixServer context={remixContext} url={request.url} />,
       {
         onShellReady: () => {
-          let body = new PassThrough();
+          const body = new PassThrough();
 
           responseHeaders.set("Content-Type", "text/html");