⚠️ No Changeset found

Latest commit: 612b20c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Hi @Bastian,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

I raised a similar report for Remix over in remix-run/remix#10409 and had narrowed it down to the v3_lazyRouteDiscovery flag, but I hadn't realised it was also possible to replicate in a production build!

Whoops, I don't know how I missed your already existing issue. At least I can confirm, that it is still an issue in v7 :)

A workaround that works (for my use-case) is to prevent double calling using a ref value:

const navigate = useNavigate();
const navigating = useRef(false);

useEffect(() => {
    if (navigating.current) {
        return;
    }
    void navigate("/somewhere");
    navigating.current = true;
}, [navigate]);

Whoops, I don't know how I missed your already existing issue. At least I can confirm, that it is still an issue in v7 :)

A workaround that works (for my use-case) is to prevent double calling using a ref value:

const navigate = useNavigate();
const navigating = useRef(false);

useEffect(() => {
    if (navigating.current) {
        return;
    }
    void navigate("/somewhere");
    navigating.current = true;
}, [navigate]);

Thank you, it worked for me. I had this problem with the v3_lazyRouteDiscovery flag enabled and your workaround seems to fix it.

On the other note, I'm curious why did you use void when calling navigate("/somewhere");?

I'm curious why did you use void when calling navigate("/somewhere");?

navigate returns a Promise in React Router v7 and I have a linter rule that forbids ignoring the results of a promise. Adding void makes it explicit that it was intentional. That's all, it does not have any effects on the code, you don't need it.

(https://typescript-eslint.io/rules/no-floating-promises#ignorevoid)