Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(how-to/suspense): update #12654

Merged
merged 1 commit into from
Dec 30, 2024
Merged

docs(how-to/suspense): update #12654

merged 1 commit into from
Dec 30, 2024

Conversation

guppy0356
Copy link
Contributor

This PR removes the unnecessary rendering of NonCriticalUI when the Await component is used.

Since the Await component handles loading states and delays rendering of its children until the awaited resource is ready, rendering NonCriticalUI is redundant.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d6a5353

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 28, 2024

Hi @guppy0356,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 29, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@MichaelDeBoey MichaelDeBoey changed the title Update documentation about suspense docs(how-to/suspense): update Dec 29, 2024
@timdorr
Copy link
Member

timdorr commented Dec 30, 2024

Thanks!

@timdorr timdorr merged commit 0c855c3 into remix-run:dev Dec 30, 2024
1 check passed
@guppy0356 guppy0356 deleted the update-doc-suspense branch December 30, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guppy0356 @timdorr @MichaelDeBoey